Comments (5)
Any movement on this?
from core.
Hi, yes, @lil-kim did some investigation work on the design side and discovered the issue is much more complex than simply fixing the alignment of the icon.
For example, if you have nested grouping with icons and collapse the navigation, the alignment is such that you can still tell which icons are children of other icons:
Long story short - this component is still in beta and we've realized we have much work to do on it to get the experience correct - especially once we start considering other breakpoints besides desktop, which this beta component does not do.
As a workaround, you can apply a margin to the icon to center align it, here is a stackblitz:
cds-navigation-item cds-icon {
margin-left: var(--cds-global-space-5);
}
from core.
Excellent thanks @ashleyryan for the update.
from core.
Thanks for the update, @ashleyryan!
We don't currently have any nested items in our nav bar so I didn't even notice what was going on with those secondary labels/icons.
There is some angular documentation on clarity.design that seems to resolve this by only applying icons to the top level navigation items (I think this helps keep visual clutter to a minimum as well). Though not as clearly illustrated, it also looks like, if a collapsed top level item with a carrot is clicked, the nav bar expands to reveal secondary items.
That workaround should be sufficient for now though. Thanks!
from core.
That documentation is for the older clr/angular component, it doesn't necessarily apply to the newer Core component - though as we update the component we may bring some of that in.
from core.
Related Issues (20)
- `CdsButton` and `CdsControlAction` not receiving `keydown` events in tests HOT 1
- Selection in multiple "select" is invisible when out of focus HOT 2
- Clicking on the resizing handle triggers click on the column header
- Update ramda dependency to ^0.29.0 HOT 2
- Angular app won't compile with Clarity HOT 4
- Missing content in icon documentation
- Empty .svg file HOT 10
- [pdfFileIcon] unclear where to import the pdf file icon from HOT 2
- Breadcrumb not updated when children are deleted
- Local `npm install` errors out on Node.js v20
- Reset cds-file input
- cds-file custom buttonLabel resets to "Browse" on clearing files
- cds-select + Vitest + React Testing Library + jsdom: `TypeError: 'set' on proxy: trap returned falsish for property 'disabled'` HOT 2
- cds-layout styles are not applied to cds-grid-footer
- Failed to execute 'define' on 'CustomElementRegistry': the name "clr-icon" has already been used with this registry HOT 3
- ```cds-dropdown``` should scroll with parent viewport HOT 1
- `cds-dropdown` storybook stories do not show sample code to implement HOT 3
- Allow more CSS custom properties on `cds-accordion-header` HOT 2
- Icon display issue when adding custom css HOT 1
- Setting `cds-motion="off"` in `CdsSelect` doesn't turn off `cds-button-expand` animation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.