Git Product home page Git Product logo

Comments (2)

ashleyryan avatar ashleyryan commented on August 15, 2024

As of v6, if using rollup (or vite, which uses rollup), you may need the @rollup/plugin-node-resolve package in your rollup config. #100

from core.

astorije avatar astorije commented on August 15, 2024

Adding a few elements here, in case it's helpful for a comprehensive upgrade guide:

  • v6's deprecated CdsInlineButton doesn't work right on its own as the styling is incorrect. This gets resolved if a single CdsButtonInline gets imported in the project. We resolved this by renaming our CdsInlineButton into CdsButtonInline (which could use a mention in the upgrade guide)

  • This same CdsInlineButton does not render its role correctly. Same resolution as above.

  • We use an ℹī¸ icon as input action, and it is now misaligned: Screen Shot 2022-05-25 at 2 12 08 PM (v6) vs. Screen Shot 2022-05-25 at 2 12 25 PM (v5)
    See #87 for more context

  • Internal components have been renamed so you might want to mention that in an upgrade guide. I realize they're supposed to be internal, but I opened a discussion about it since one of them were introduced for us (therefore not internal): #94

  • Upgrade guide should mention the CSS shims in Core must be removed.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.