Using **kwargs in _connect() of DeviceComms and DccComms about liota HOT 3 CLOSED

Hi @bfrggit,

Could you please explain why self._connect() should be kept free of external arguments as mentioned in the comment here ?

If it is to facilitate dynamic number of arguments as each transport requires different arguments, why don't we use _connect(**kwargs) instead ?

Adding @KohliDev

from liota.

We want to keep the parameters.

At the same time, if we put the parameters in _connect(), it gives the possibility that some one call this method on the same obj multiple times with different parameters, which may cause troubles.

Of course you could always resolve these problems in some ways, whether you decide to use an init() or use _connect() directly. We just decided to use the first manner. In this way it might also be more consistent with other modules and classes.

from liota.

Oh okay. Thanks for explaining.

from liota.