Comments (13)
pmasrani
commented on July 28, 2024
Issue was incorrect usage of log.error to log the stacktrace. log.exception should be used for printing stacktrace. Corrected in review: #125
from liota.
KohliDev
commented on July 28, 2024
Okay. I would also suggest reviewing the multiple places where log.error is used in the liota codebase in case we require to change it to log.exception as it fixes the issue.
from liota.
pmasrani
commented on July 28, 2024
traceback module is used only in this location.
from liota.
KohliDev
commented on July 28, 2024
Issue occurs at multiple places in log files:
2017-05-18 19:27:54 PDT 5721 INFO [PackageThread] liota.core.package_manager.run(355) - Got message in package messenger queue: list pkg
2017-05-18 19:27:54 PDT 5721 WARNING [PackageThread] liota.core.package_manager._cmd_handler_list(257) - List of packages - __\n__
2017-05-18 19:28:18 PDT 5721 INFO [PackageThread] liota.core.package_manager.run(355) - Got message in package messenger queue: load edge_systems/dell5k/edge_system 626d4caddc37bb7958e5a491126733d2bc0f6aa3
2017-05-18 19:28:18 PDT 5721 INFO [PackageThread] liota.core.package_manager._package_load(567) - Loaded package file: /etc/liota/packages/edge_systems/dell5k/edge_system.py (626d4caddc37bb7958e5a491126733d2bc0f6aa3)
2017-05-18 19:28:18 PDT 5721 INFO [PackageThread] liota.lib.utilities.utility.get_uuid(108) - resource: EdgeSystem-Name uuid=113294af-1770-547d-9b80-0cbe3cae02e1
2017-05-18 19:28:18 PDT 5721 INFO [PackageThread] liota.core.package_manager._package_load(644) - Package class from module edge_systems/dell5k/edge_system is initialized
2017-05-18 19:28:32 PDT 5721 INFO [PackageThread] liota.core.package_manager.run(355) - Got message in package messenger queue: list pkg
2017-05-18 19:28:32 PDT 5721 WARNING [PackageThread] liota.core.package_manager._cmd_handler_list(257) - List of packages - __\n__ edge_systems/dell5k/edge_system
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(149) - endpoint_list:(disc_msg_pipe : /etc/liota/packages/dev_disc/discovery_messenger.fifo)__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(158) - type_key_map:(Press64 : serial)__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(158) - type_key_map:(LM35 : SN)__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(158) - type_key_map:(Banana23 : serial)__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(158) - type_key_map:(Apple56 : SN)__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(170) - type_dcc_map:(Press64 : ['iotcc_mqtt', 'iotcc'])__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(170) - type_dcc_map:(LM35 : ['graphite', 'iotcc_mqtt', 'iotcc'])__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(170) - type_dcc_map:(Banana23 : ['iotcc'])__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(170) - type_dcc_map:(Apple56 : ['iotcc_mqtt', 'iotcc'])__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(172) - type_tuple_key_dcc_pkg:(Press64 : ('serial', ['iotcc_mqtt', 'iotcc']))__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(172) - type_tuple_key_dcc_pkg:(LM35 : ('SN', ['graphite', 'iotcc_mqtt', 'iotcc']))__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(172) - type_tuple_key_dcc_pkg:(Banana23 : ('serial', ['iotcc']))__\n__
2017-05-19 00:18:26 UTC 1133 DEBUG [PackageThread] liota.core.device_discovery._get_config_from_file(172) - type_tuple_key_dcc_pkg:(Apple56 : ('SN', ['iotcc_mqtt', 'iotcc']))__\n__
from liota.
KohliDev
commented on July 28, 2024
@pmasrani This issue exist in liota-0.3 beta release. Any progress on this issue?
from liota.
pmasrani
commented on July 28, 2024
It is not a good practice to have multi-line logs, except for stack traces as those logs can't be parsed well by log parsers. It is up to individual module owner to make sure they add logs in good format, without using \n. Assigning to Winnie to take a look at package manager and device discovery logs.
from liota.
pmasrani
commented on July 28, 2024
@winniex1 Can you please make sure that logs in Package Manager and Device discovery modules do not use \n.
from liota.
winniex1
commented on July 28, 2024
Ok. I’ll have a look on it.
From: pmasrani <[email protected]<mailto:[email protected]>>
Reply-To: vmware/liota <[email protected]<mailto:[email protected]>>
Date: Monday, June 19, 2017 at 12:26 AM
To: vmware/liota <[email protected]<mailto:[email protected]>>
Cc: Winnie Xu <[email protected]<mailto:[email protected]>>, Mention <[email protected]<mailto:[email protected]>>
Subject: Re: [vmware/liota] Logging formatter issue to remove new lines (#124)
@winniex1<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_winniex1&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=54wxBBgClSRBBXaBt0Kekq9NfQLtmAiEdfbOmTtERuE&s=zaHHXpnh9IOe-tvjZ-GcEM_ubzMC9ZnWZRU5WN6VbHM&e=> Can you please make sure that logs in Package Manager and Device discovery modules do not use \n.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_vmware_liota_issues_124-23issuecomment-2D309360087&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=54wxBBgClSRBBXaBt0Kekq9NfQLtmAiEdfbOmTtERuE&s=WsML-irzrV6N3WqlrN-zfmgRRwQx6O-4i-GVqcUcOeg&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQ5FBnD-2DxwtNdTe0iWX8uJWrEc497Zzpks5sFiKzgaJpZM4NSFF-2D&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=54wxBBgClSRBBXaBt0Kekq9NfQLtmAiEdfbOmTtERuE&s=yiO0TmDDHTcOXZYUp7yCtuzTD5wkmrJUOzhpm-J86nE&e=>.
from liota.
KohliDev
commented on July 28, 2024
@winniex1 & @bfrggit Can you please look into this issue?
from liota.
winniex1
commented on July 28, 2024
@Vaibhav remembered we said to check in after master is stable status.
@ bfrggit you may fix package manager part. I’ll fix device discovery
From: Vaibhav Kohli <[email protected]>
Reply-To: vmware/liota <[email protected]>
Date: Tuesday, August 22, 2017 at 8:03 AM
To: vmware/liota <[email protected]>
Cc: Winnie Xu <[email protected]>, Mention <[email protected]>
Subject: Re: [vmware/liota] Logging formatter issue to remove new lines (#124)
@winniex1<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_winniex1&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=lxsLq2JotzXwDQHDfqPSdITMKhtSWZ_OaJ18gpUZmG0&s=JfC_gonozdR2XRYXiXtIbgiu1bl9sFfntkXFf6h-0Lw&e=> & @bfrggit<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_bfrggit&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=lxsLq2JotzXwDQHDfqPSdITMKhtSWZ_OaJ18gpUZmG0&s=Og3YvMqSTVaZ_rJCHjReQYXAD9w0CDdWon6TCEt12P4&e=> Can you please look into this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_vmware_liota_issues_124-23issuecomment-2D324054745&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=lxsLq2JotzXwDQHDfqPSdITMKhtSWZ_OaJ18gpUZmG0&s=_saV5URstO1sqSEmEDYfg_RcI-xircgtljIr_r700po&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AQ5FBpFTX8dojOGl-2DADdgvjGwmbZL4mdks5sau2ggaJpZM4NSFF-2D&d=DwMCaQ&c=uilaK90D4TOVoH58JNXRgQ&r=uFdr42bgurjylqTd0Nv4o6OM9loF-lqPsPl1VqqWXgk&m=lxsLq2JotzXwDQHDfqPSdITMKhtSWZ_OaJ18gpUZmG0&s=fXgw8wNCMBDRjUCzGN6jcou_RDBix4bOLCLqzUJPqUc&e=>.
from liota.
bfrggit
commented on July 28, 2024
@winniex1 Okay. I will change the package manager. Just change the output format to remove the newlines I guess?
from liota.
bfrggit
commented on July 28, 2024
Okay. I will change the package manager. Just change the output format to remove the newlines I guess?
For the package manager stats -
I just mentioned this to @pmasrani. It seems that we do not want to simply change \n to spaces since "stats are still unreadable" in that way.
@pmasrani proposed two potential fixes:
-
Output stats back to where the command is invoked. This requires some changes, since we may need a different pipe (or similar) to get those info back. The
liotapkg.shscript also needs to be changed so it listens to that "different pipe" after command is written. -
Quicker fix: Create a different log file somewhere else, that contains package manager's logs, or perhaps just package manager's stat outputs. This requires changes in package manager only in Liota, but requires additional info in Liota config. Now we only have one Liota log file that contains everything. By doing this, we are starting different log files.
If this is not urgent before VMworld, we may want to discuss a little before I or anyone else actually make the changes.
from liota.
KohliDev
commented on July 28, 2024
Any update on this issue as this needs to be fixed before we roll out latest release of Liota.
from liota.
Related Issues (20)
- Should it be enforced only one Liotad running on the EdgeSystem
- Syslog mechanism in Liota
- Developer Guide required for Liota
- Build Liota "SNAP" HOT 1
- Liotapkg.sh returns package manager not running inspite it is running
- Liota Package manager should handle independent packages loading in parallel
- Debian and RPM versions to be created for Liota
- Exit status should be non-negative value
- Check the possible approach to merge setup.py of Liota and Liota-lite
- /usr/lib/liota is not created with pip install HOT 3
- autostartliota script contains wrong liotad.py path HOT 1
- unset_property call to be designed in Liota
- Client certificate support MQTT provide examples
- Re-visit metric handler design
- Revisit sha1sum checksum mechanism for the dependent packages.
- 请问是否有中文版本示例与文档？ HOT 5
- No module named 'pip.req' HOT 1
- Run liota on an esp8266/esp32 HOT 7
- Considerations on comparing to Apache MiNiFi and StreamSets's data collector edge
- Profinet example
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liota.