Git Product home page Git Product logo

Comments (4)

JalonSolov avatar JalonSolov commented on June 2, 2024 1

Since ; is now valid in V, this looks like an unreachable code thing since V will exit because of the panic.

from v.

hholst80 avatar hholst80 commented on June 2, 2024

It seems there is also a related issue with nesting?

		event := json2.decode[Event](req.data) or {
			eprintln(err)
			conf := http.ResponseConfig{
				status: .internal_server_error
		  	header: http.new_header(http.HeaderConfig{ key: .content_type, value: 'text/plain' })
		  	body: "${err}"
			}
			con.close() or { panic(err) }
		}
src/main.v:40:8: error: `or` block must provide a default value of type `Event`, or return/continue/break or call a [noreturn] function like panic(err) or exit(1)
   38 |               body: "${err}"
   39 |             }
   40 |             con.close() or { panic(err) }
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~
   41 |         }
   42 |         // req := http.parse_request(mut buf_reader)!

EDIT:

I misunderstood the error. The error is resolved by adding a panic after the close statement. The error originated from the first if block.

		event := json2.decode[Event](req.data) or {
			eprintln(err)
			conf := http.ResponseConfig{
				status: .internal_server_error
		  	header: http.new_header(http.HeaderConfig{ key: .content_type, value: 'text/plain' })
		  	body: "${err}"
			}
			con.close() or { panic(err) }
			panic(err)
		}

from v.

JalonSolov avatar JalonSolov commented on June 2, 2024

Yes, which is a separate error. With the ;, it looks like unreachable code. Without the ;, it is wrong in that a default value isn't required since it would exit before that extra code was reached.

Both could be handled by the seeing that it will exit, but it would be more clear to have 2 separate errors.

from v.

JalonSolov avatar JalonSolov commented on June 2, 2024

Oh, and although the ; is accepted, v fmt will remove it, as it is not needed for anything (other than some cases with -e on the command line).

from v.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.