iframe in a raw directive breaks the home page about tinkerer HOT 3 CLOSED

vladris commented on July 28, 2024

iframe in a raw directive breaks the home page

from tinkerer.

Comments (3)

vladris commented on July 28, 2024

This looks like an upstream bug. Tinkerer runs each post page through PyQuery to patch some relative links and other stuff. Looks like in the process, <iframe ...></iframe> gets turned into <iframe />. This seems to be the reason browser doesn't read this correctly. There is no particular logic for dealing with iframes, so this is either PyQuery or lxml issue that it collapses open and closed tags into a single one. I'll dig some more into it if I have time to spare, but I doubt I can locally fix it in Tinkerer...

from tinkerer.

vladris commented on July 28, 2024

Looks like this happens with any open/closed tags with no content. On the other hand, there seems to be a simple fix: just add a space between the iframe tags. The parser will consider it as content and it will no longer collapse them into a single tag.

I'll Won't Fix this issue since there is a simple workaround and it's an upstream problem anyway.

from tinkerer.

sgillies commented on July 28, 2024

@vladris thanks for the workaround recommendation!

from tinkerer.

Related Issues (20)

• CSS: Fix default theme sidebar on wide, short windows.
• Search results contain broken links HOT 1
• Remove posts HOT 2
• RemovedInSphinx17Warning for Directive
• Remove Python 2.7 support
• Could not import extension tinkerer.ext.blog (exception: cannot import name 'Directive') HOT 3
• Could not import extension tinkerer.ext.blog (exception: No module named builtins) HOT 2
• Build error with Sphinx-1.8.1 HOT 2
• Allow configuration of builddir (paths.blog, paths.html etc.) in conf.py HOT 1
• Project dead? HOT 1
• Bypassed: Use sphinx 1.7.1 in combination with tinkerer and sphinx 3.1.2 as standalone
• Steps to use Docker to install Tinkerer and (re)generate blog
• HTTPS support on external resources
• Add support for incremental build HOT 2
• theme.conf - pygments_style has no effect on _static/pygments.css
• submodule
• Warning on html_add_permalinks HOT 1
• Why not add '# -*- coding:utf-8 -*-' in the py file header? HOT 3
• Error when using sphinx themes
• Make build path `blog` configurable HOT 1