Git Product home page Git Product logo

Comments (7)

vladotesanovic avatar vladotesanovic commented on July 19, 2024 3

Repository ( demo ) and library from npm are on rc.1 now.

from ngsemantic.

TerryMooreII avatar TerryMooreII commented on July 19, 2024

+1

from ngsemantic.

TerryMooreII avatar TerryMooreII commented on July 19, 2024

I was able to migrate the ng-semantic components to angular 2 rc with relative ease. I had to copy the ng-semantic directory to my project in order to build it but things did work.

I was not however able to migrate the documentation to rc due to some dependant packages that have not been updated to angular 2 rc. This is why I had to copy the ng-semantic folder to my project instead of running the ng-semantic node bundle scripts. I will keep an eye on those dependencies or keep looking for workarounds in order to get this project up to the latest version of angular 2.

I can push my branch later tonight if anyone is interested in hacking away on it.

from ngsemantic.

vladotesanovic avatar vladotesanovic commented on July 19, 2024

Yes, please submit it as PR.

I am going to update this project to rc.1 tonight, i didn't work on it last month, but i am going to push it harder in next few days / weeks.

from ngsemantic.

TerryMooreII avatar TerryMooreII commented on July 19, 2024

I dont want to submit a pull request because this branch isnt fully working....yet. You can check out my current progress on this branch https://github.com/TerryMooreII/ngSemantic/tree/angular2-migration

Bundle now runs successfully

$ tsc && node bundle.js && cp ./bundles/ng-semantic.js ./demo/vendor
Build complete.
Minified build complete.

But npm run demo:build fails with this message

$ npm run demo:build

> [email protected] demo:build /Users/terrymooreii/code/github/ngSemantic
> rm -rf demo/app && tslint -c ./tslint.json 'src/app/**/*.ts' && tsc -p './src' --rootDir './src' --outDir './demo' && cd src && find . -name '*.html' | cpio -pdm ../demo

node_modules/ng2-src-directive/src/sourcable.d.ts(3,21): error TS7006: Parameter 'string' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(6,21): error TS7006: Parameter 'string' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(9,19): error TS7006: Parameter 'any' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(12,22): error TS7006: Parameter 'Response' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(15,22): error TS7006: Parameter 'string' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(16,22): error TS7006: Parameter 'string' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(17,20): error TS7006: Parameter 'any' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/sourcable.d.ts(18,23): error TS7006: Parameter 'Response' implicitly has an 'any' type.
node_modules/ng2-src-directive/src/src.directive.d.ts(1,10): error TS2305: Module '"/Users/terrymooreii/code/github/ngSemantic/node_modules/@angular/core/index"' has no exported member 'AppViewManager'.

npm ERR! Darwin 15.4.0
npm ERR! argv "/usr/local/Cellar/node/5.11.0/bin/node" "/usr/local/bin/npm" "run" "demo:build"
npm ERR! node v5.11.0
npm ERR! npm  v3.8.6
npm ERR! code ELIFECYCLE
npm ERR! [email protected] demo:build: `rm -rf demo/app && tslint -c ./tslint.json 'src/app/**/*.ts' && tsc -p './src' --rootDir './src' --outDir './demo' && cd src && find . -name '*.html' | cpio -pdm ../demo`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] demo:build script 'rm -rf demo/app && tslint -c ./tslint.json 'src/app/**/*.ts' && tsc -p './src' --rootDir './src' --outDir './demo' && cd src && find . -name '*.html' | cpio -pdm ../demo'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ng-semantic package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     rm -rf demo/app && tslint -c ./tslint.json 'src/app/**/*.ts' && tsc -p './src' --rootDir './src' --outDir './demo' && cd src && find . -name '*.html' | cpio -pdm ../demo
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ng-semantic
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ng-semantic
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/terrymooreii/code/github/ngSemantic/npm-debug.log

The ng2-src-directive package is pulled in from ngSemantic's dependency on ng2-prism which is still at Angular 2 beta. I am not sure how to work around these issues until the ng2-prism is updated. Any help would be appreciated.

from ngsemantic.

jameswestnz avatar jameswestnz commented on July 19, 2024

I've done the same - found that everything was working but the demo, so ditched it and included ng-semantic in my project instead.

If we have solid tests in place, do we need the demo as part of this package? I'm thinking that many people will simply install through npm then copy and paste from your demo etc. Could even have a readme for each component that has a copy-and-paste example for users to get going.

I've added some more components myself (well, added other options such as password input type so far), so will contribute back once they're stable at our end, and you've got an RC version up here.

Let me know if you have any questions :)

from ngsemantic.

aaweb avatar aaweb commented on July 19, 2024

@vladotesanovic: Any news on this from last time? :)

from ngsemantic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.