Fail to build with newer rustc about veridian HOT 5 CLOSED

I'm not sure exactly why but as of #179 it seems to be building on newer rust versions, I just tested it on rust 1.74.1

from veridian.

Thanks! I've just tested with rustc 1.75.0 (82e1608df 2023-12-21)

cargo install --git https://github.com/vivekmalneedi/veridian.git --all-features

and it installs fine in a fedora-minimal container (it needs clang-libs for libclang.so and openssl-devel to build).
I tried again also running tests (after reading my previous message) with cargo test --all-features after cloning the repo:

failures:

---- diagnostics::tests::test_verible_syntax stdout ----
thread 'diagnostics::tests::test_verible_syntax' panicked at src/diagnostics.rs:298:74:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    diagnostics::tests::test_verible_syntax

test result: FAILED. 20 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

Would it be better to track this feature in a new issue and close this one?

from veridian.

that test is for syntax checking with verible so if that isn't installed it will fail. I guess it could show a nicer error message but it's just a test so I haven't bothered.

from veridian.

I do not know any rust... is something like this acceptable?

        let errors = verible_syntax(&doc, "verible-verilog-syntax", &[])
            .expect("verible-verilog-syntax not found, test not run");

reference

from veridian.

yes, that would work as a better error message, ideally we would be able to skip the test if verible wasn't present but I don't think that functionality exists in the cargo test runner.

from veridian.