Comments (5)
It looks like float64
is the default for numpy, so we'd only get np.float128
if someone specified that explicitly, which seems unlikely. We could remove these and note in the docs that we don't support those data types?
from vivarium-core.
who put those in and why? Can you check the git blame @cyrus-bio?
Maybe we can check if the type exists, and only use it if it does?
from vivarium-core.
From a cursory search it seems that most people just use np.float64 at most, or do something along the lines of:
if hasattr(np, 'float128'): do A else: do B
from vivarium-core.
I think I put those in. They just tell Vivarium that the numpy serializer should be used for objects of type np.float128
. If someone does provide a np.float128
object after we remove the np.float128
reference from this file, nothing will break. Vivarium will just take slightly longer to find the right serializer (it will loop through the serializers instead of looking the right serializer up in a dictionary)
from vivarium-core.
Sounds like we can safely remove it then. @cyrus-bio -- want to open a pull request in vivarium-core?
from vivarium-core.
Related Issues (20)
- Use the Apache License
- Improve / Replace isinstance() checks
- Make instance methods into class methods or static methods where possible
- Permissions and Responsibilities Structure HOT 1
- Update Documentation HOT 1
- Post-v1.0.0 Documentation Updates
- Interrupts for Engine HOT 2
- Process Serialization with Inheritance HOT 3
- Stop adding units to emitted data keys
- More flexible topology rewiring for glob schemas HOT 5
- Improve Handling of Process Parameters and Defaults HOT 2
- Pull Schema, Topology, and Hierarchy Utilities into Separate Library
- vivarium-core requires pytest HOT 1
- Proposal: Multiple Production Branches
- Proposal: Improved Handling of Parallel Processes HOT 3
- Handling Multi-Updates
- External Controls for Dealing with Conflicting Updaters
- Schema validation fails with Numpy arrays
- Publish v1.6.1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vivarium-core.