Comments (6)
I would definitely accept a PR for impl PartialOrd
for all types! I think you should be able to just #[derive(PartialOrd)]
on them.
from path_abs.
It should already be implemented actually?
https://github.com/vitiral/path_abs/blob/master/src/arc.rs#L37
I found a similar derive for PathFile
as well. Is it missing elsewhere?
from path_abs.
It should already be implemented actually?
Totally my fault!! I thought cmp()
was part of PartialOrd
, but is in Ord
trait instead. PathAbs is working as expected with PartialOrd
and PartialEq
.
On the other hand, My fault again, they are also implemented! It seems I am too tired to keep programming today. πOrd
and Eq
traits are also implemented for Path and PathBuf. It would be interesting to have them. Should I open a different issue or rename this one?
from path_abs.
from path_abs.
Go ahead and rename this one, and feel free to open a PR to add Ord and Eq
No need, they are working as expected. Sorry for the noise!
from path_abs.
π
from path_abs.
Related Issues (20)
- Idea: Give FileWrite a `write_fmt` inherent method HOT 2
- Making Stdio from {FileRead, FileWrite} HOT 2
- Help in handling weird join behavior HOT 16
- resolving resulted in empty path when resolving absolute . HOT 4
- Notes from a new user HOT 8
- Move PathArc to botom of docs and make it more clear that it is an implementation detail HOT 1
- `PathAbs` has incorrect docs HOT 2
- Remove `arc::handle_prefix()` HOT 6
- What should happen when canonicalizing `..` at the root? HOT 3
- Internationalization (i18n) support
- Types probably shouldn't implement the `Deref` trait. HOT 9
- PathAbs constructor cleanup HOT 2
- windows path handling HOT 5
- Add `join` back HOT 1
- File* Constructor cleanup
- put join fn in PathOps
- Inherent methods for PathOps and PathInfo HOT 6
- add wasm32-wasi target HOT 2
- WASI symlink implementation is incorrect HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from path_abs.