SvelteKit 1.3.1+ not working about sveltekit HOT 8 CLOSED

The workaround is downgrade to 1.3.0, we're working to fix it.

from sveltekit.

It seems a regression in 1.3.1: kit closeBundle hook is called only on client build, and must be called only in server build.

from sveltekit.

Please try with @sveltejs/kit version 1.3.7

from sveltekit.

@benmccann adapter still being called before pwa plugin, I'll try with a fresh install.

from sveltekit.

The problem is that the PWA plugin is generating its files after SvelteKit calls await vite.build to invoke the client build and it returns. There's probably a missing await somewhere in Vite or the PWA plugin or something. Everything in SvelteKit looks okay as far as I can tell.

I think when SvelteKit's client build was running first it was just covering this issue up

from sveltekit.

This is a bug in Vite. It's not using an await when calling bundle.close()

from sveltekit.

This issue title & post is not descriptive; is this related to this error in Sveltekit on recent versions?

pnpm add @vite-pwa/sveltekit -D
# add SvleteKitPWA to vite.config.ts as in docs
pnpm run dev

failed to load config from C:\GitHub\MyStuff\Someplice\vite.config.ts
error when starting dev server:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'vite-plugin-pwa' 

from sveltekit.

@drewbitt

This issue is about kit and vite changes breaking the pwa plugin . It seems Vite bug is fixed, now we need to update this plugin to run with latest kit changes, check PR pages, we need to review a few things and we should release a new version soon.

from sveltekit.