Git Product home page Git Product logo

Comments (2)

VitaliiTsilnyk avatar VitaliiTsilnyk commented on May 26, 2024

In the current implementation Catalog is thread safe if you don't modify the Translations dictionary manually but use the loader in the constructor (and also you should use the ICatalog interface everywhere as it only exposes the translation methods).
Read operations of Dictionary are thread safe unless you concurrently write into it.
I understand that exposing a non thread safe property makes the current implementation unsafe, it has been done to keep backwards compatibility with older versions of the library and in version 1.0 I'm planning to implement the loaders properly without exposing internal stuff.

from ngettext.

hmqgg avatar hmqgg commented on May 26, 2024

Thanks for your clarification. I noticed that some targeted frameworks don't support ConcurrentDictionary so I can understand why not simply change it.

And I agreed with that ILoader implementation needs to rewrite in order to avoid exposing Translations.

Issue closed.

from ngettext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.