Git Product home page Git Product logo

Comments (6)

vitalets avatar vitalets commented on June 5, 2024

hi @christianacca
please try with just released 0.1.6
also note that <button> without type attribute works as submit by default. I've seen it in your plunkr..

from angular-xeditable.

christianacca avatar christianacca commented on June 5, 2024

Will try this out tomorrow afternoon. Thanks for the good work Vitaliy.

On Sat, Oct 19, 2013 at 4:59 PM, Vitaliy Potapov
[email protected]:

hi @christianacca https://github.com/christianacca
please try with just released 0.1.6
also note that without type attribute works as submit by
default. I've seen it in your plunkr..


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-26652573
.

from angular-xeditable.

christianacca avatar christianacca commented on June 5, 2024

OK, so the suspense was killing me so I couldn't wait until tomorrow :-)

I toyed around with http://jsfiddle.net/christianacca/gpgD4/ and the code is much better.

I still need to employ one hack to ensure that the first input of the newly added row has focus. I needed a custom directive 'focusMe' and scheduling user.isFocused = true within a $timeout.

Here's the significant parts of code (from the above jsfiddle) for adding a user:

  $scope.addUser = function() {
    var newUser = {
      id: $scope.users.length ...
    };
    $scope.users.push(newUser);

    if (!$scope.tableform.$visible) {
      $scope.tableform.$show();
    }    
    // Hack to be able to add a record and have focus set to the new row
    $timeout(function(){
       newUser.isFocused = true;
    }, 0);
  };

I think it would be more intuitive to have focus on the newly added row rather than having to perform these tricks. What do you think?

Christian

from angular-xeditable.

vitalets avatar vitalets commented on June 5, 2024

hi @christianacca
I've updated fiddle to get it working without custom directive and user.isFocused flag.
It uses some undocumented features, I think I will add it to docs.
http://jsfiddle.net/gpgD4/10/

from angular-xeditable.

christianacca avatar christianacca commented on June 5, 2024

I knew you would have a solution up your sleeve! Thanks Vitaliy

On Mon, Oct 21, 2013 at 7:42 AM, Vitaliy Potapov
[email protected]:

hi @christianacca https://github.com/christianacca
I've updated fiddle to get it working without custom directive and
user.isFocused flag.
It uses some undocumented features, I think I will add it to docs.
http://jsfiddle.net/gpgD4/10/


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-26695529
.

from angular-xeditable.

vitalets avatar vitalets commented on June 5, 2024

y're welcome )

from angular-xeditable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.