Git Product home page Git Product logo

Comments (5)

chenwydj avatar chenwydj commented on June 9, 2024

Hi @jianyin2016,

Thank you for your interest in our work!

  1. C.train_portion = 0.5 in config_search.py
  2. train_loader_model and train_loader_arch are built in train_search.py, with half-half split training data for updating model weights and architecture parameters, respectively.
  3. Each dataset object get split in the whole training data based on the portion in BaseDataset.py.

I double verified: train_loader_model and train_loader_arch get 1487 and 1488 images, which are disjointed.

Hope this helps!

from fasterseg.

jianyin2016 avatar jianyin2016 commented on June 9, 2024

Hi, @chenwydj
Did you dive into the name list of the two dataloader?I calculated the intersection between the 1487 images and 1488 images ending up with a overlapped list with length about 70.
I think this is caused by the shuffle calling of the whole training data before you get the former half and the latter half, everytime you initialize a dataloader there is a shuffle call, and the shuffled results are not the same even with a common random seed.what you want is W->shuffledW->shuffledW[:len(W)/2]train_loader_model+shuffledW[len(W)/2]train_loader_arch, but what you actually get is W->shuffledW1->shuffledW1[:len(W)/2]train_loader_model+W->shuffledW2->shuffledW2[len(W)/2]train_loader_arch.

from fasterseg.

chenwydj avatar chenwydj commented on June 9, 2024

You are right. Thank you very much for pointing it out!

I have updated BaseDataset.py where shuffle(files) is applied after the dataset splitting.

from fasterseg.

jianyin2016 avatar jianyin2016 commented on June 9, 2024

I don't think it is a good choice to just applying shuffle(files) after the dataset splitting cause the files are sorted before splitting, this may result in severe class imbalance between trainA and trainB, I would suggest to provide the dataloader class with a shuffled filenames as param for my limited engineering experinece.
I am wondering how will this affect the finally results? If you have any futher results, plz let me know.
Thanks for your work.

from fasterseg.

chenwydj avatar chenwydj commented on June 9, 2024

Thanks again for the suggestion! You are right, and sorry for my rush update.

In the latest push I first build a shuffled list of index, and then do the dataset split in two dataloaders based on this shared list of index.

Thank you again!

from fasterseg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.