Custom template not displayed in browser about express-messages HOT 8 OPEN

I think html generated in callback via render in too late and function returns default empty output:

      if (template) {
        locals = locals || {};
        locals.messages = flash;
        res.render(template, locals, function (err, html) {
          if (html) {
            output = html;
          }
        });
      } else {
         //...
      }
      return output; // I THINK THIS LINE WINS TO CALLBACK IN RENDER

from express-messages.

Not quite sure what is going on here, paging @agraboso!

from express-messages.

Any movement on this?

from express-messages.

Paging @agraboso again!

from express-messages.

I believe @akobashikawa's assessment is correct. The obvious fix would be to render the template synchronously, but express disallows that by not exposing the rendering engine(s). We might have to simply import a templating library...

from express-messages.

Thanks @agraboso. Would that not end up to blocking the request though? Is there any way to handle this async? Maybe we could take in next and call that from within the function or change the signature to return our own callback?

from express-messages.

@artcommacode: I don't see how to do this async at all. After a good deal of thought, I think the best way to deal with this is to delegate rendering to the user in exactly the way flash does — so maybe we should deprecate this module and point users to flash.

from express-messages.

so we can't use custom template for this package ....

from express-messages.