Git Product home page Git Product logo

Comments (13)

gnavvy avatar gnavvy commented on April 28, 2024

We can add support to allow radius defined based on real-world distances (e.g. 10km radius).
Though I have to deprioritize this for now, at least after the full geoJson geometry type support.

but PR is always welcomed : )

from deck.gl.

yocontra avatar yocontra commented on April 28, 2024

@gnavvy ScatterPlotOverlay should redraw if the radius option changes, right? Can't seem to get that to work.

from deck.gl.

gnavvy avatar gnavvy commented on April 28, 2024

depends. the default radius will scale with the zoom (derived from a ∆latitude) but for now if you pass in your own radius, it will override the default one.
https://github.com/uber/deck.gl/blob/master/src/layers/scatterplot-layer/scatterplot-layer.js#L133

from deck.gl.

yocontra avatar yocontra commented on April 28, 2024

@gnavvy Default radius doesn't seem to be scaling right.

screen shot 2016-08-15 at 5 13 30 pm

screen shot 2016-08-15 at 5 13 39 pm

from deck.gl.

gnavvy avatar gnavvy commented on April 28, 2024

could you elaborate on what is the problem with the scaling? the radius was defined to be approximately the same with the street size (bottom image) but became larger (top image) than expected when zoom in?

from deck.gl.

yocontra avatar yocontra commented on April 28, 2024

@gnavvy Looks fine on lower zoom levels, but on higher zoom levels the dots become extremely large and eventually obscure the entire viewport.

This is with a ScatterplotLayer that has no radius parameter given, so being calculated here: https://github.com/uber/deck.gl/blob/master/src/layers/scatterplot-layer/scatterplot-layer.js#L138-L144

Here's what I'm trying to achieve:

screen shot 2016-08-16 at 3 01 46 pm

screen shot 2016-08-16 at 3 01 16 pm

from deck.gl.

gnavvy avatar gnavvy commented on April 28, 2024

I see, so basically a maximum radius to prevent the points from getting too large.
will add the support together with #54

from deck.gl.

gnavvy avatar gnavvy commented on April 28, 2024

we might have to add more thorough solutions to allow radius:

  1. with constant screen size;
  2. with constant geo-distance;
  3. scales with zoom;
  4. scales with zoom + with max screen size;

for now, specifying both global radius at layer level and radius at per item level will lead to radius with constant screen size.

from deck.gl.

Vednus avatar Vednus commented on April 28, 2024

Specifying both global radius at layer level and radius at per item level used to give a radius with a constant screen size, but after I updated to the newest version, this doesn't seem to be working.

from deck.gl.

Vednus avatar Vednus commented on April 28, 2024

I ended up using the code outlined here to normalize the radius if anyone else is needing this: http://stackoverflow.com/questions/30703212/how-to-convert-radius-in-metres-to-pixels-in-mapbox-leaflet

from deck.gl.

ibgreen avatar ibgreen commented on April 28, 2024

@Vednus This should not be needed.

I think there is a difference between Scatterplot and Scatterplot64. The 32 bit version should behave correctly (i.e the radius should be in item radius * layerRadius meters, the latter hasn't been updated completely.

Can you confirm which layer you are using?

We've gotten some feedback that the docs need improving in this regard as well (scatterplot radius handling and interaction between props and accessor etc).

@manassra @shaojingli

from deck.gl.

Vednus avatar Vednus commented on April 28, 2024

I'm using the 32 bit version via import { ScatterplotLayer } from 'deck.gl' so I guess it's not behaving correctly...

from deck.gl.

ibgreen avatar ibgreen commented on April 28, 2024

Tracked in #264

from deck.gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.