Not working with Webpack about ngmeta HOT 4 CLOSED

The change in PR #28 seems inconsistent with the way I'm used to exporting a module. I think we should return the name property. Not sure about the rest of you.

return angular.module('ngMeta', [])
  .provider('ngMeta', function() {
    ...
  })
  .name // <-- return the name

Without returning the name, I need to

import angular from 'angular'
import 'ng-meta'

export const AppModule = angular
  .module('app', [
    'ngMeta'
  ])
  .name

And I would like to:

import angular from 'angular'
import ngMeta from 'ng-meta'

export const AppModule = angular
  .module('app', [
    ngMeta
  ])
  .name

from ngmeta.

@vinaygopinath can you check this please? we are hoping to use this in prod asap.

Thanks

McGilly

from ngmeta.

It would require a simple modification in the ngMeta.js. Just need to return the angular.module name at the end of the file. I can make the PR if needed.

from ngmeta.

@devotis Thanks for the suggestion. I'm open for the module to return the name as long as it has no impact on the way the module is imported in other build systems. Would you be willing to test it out with webpack, and, say, gulp and make a new PR?

from ngmeta.