Git Product home page Git Product logo

Comments (1)

psalm-github-bot avatar psalm-github-bot commented on August 24, 2024

I found these snippets:

https://psalm.dev/r/e76bd1defd
<?php

// Class we'll load properties-of into a property of another class
class DBLoginInfo
{
    /**
     * @param string $host 
     * @return void 
     */
    public function __construct(
        public string $host
       )
       {}
}

// Load in properties one way
class DBConnectInfoAsArray
{
    /**
     * @param properties-of<DBLoginInfo> $read
     */
    public function __construct(
        public array $read
    )
    {}
}

// Load in properties another way
class DBConnectInfoAsArray2
{
    /** @param properties-of<DBLoginInfo> */
    public array $read;
    public function __construct(array $read)
    {
        $this->read = $read;
    }
}

/**
* Fail: Try to access host from first parent class
* @param properties-of<DBConnectInfoAsArray> $info
* @return void
*/
function blah(array $info)
{
    $read = $info['read'];
    echo $read['host'];
}

/**
* Fail: try to access host from second parent class
* @param properties-of<DBConnectInfoAsArray2> $info
* @return void
*/
function blah2(array $info)
{
    $read = $info['read'];
    // This says it's just a generic array... it doesn't seem to understand the docblock type
    echo $read['host'];
}

/**
* Pass if you explicitly assign @var
* This one works by using @var to tell it what it should be, but it seems
*   like psalm should have been able to tell what it is without using an @var
* @param properties-of<DBConnectInfoAsArray2> $info
* @return void
*/
function blah3(array $info)
{
    /** @var properties-of<DBLoginInfo> */
    $read = $info['read'];
    echo $read['host'];
}

/**
* Pass if you don't use properties-of<DBConnectInfoAsArray>, and load the class itself.
* @return void
*/
function blah4(DBConnectInfoAsArray $info)
{
    $read = $info->read;
    echo $read['host'];
}
Psalm output (using commit 16b24bd):

ERROR: InvalidArrayAccess - 47:10 - Cannot access array value on non-array variable $read of type properties-of<DBLoginInfo>

INFO: MixedArgument - 47:10 - Argument 1 of echo cannot be mixed, expecting string

INFO: PossiblyUndefinedStringArrayOffset - 59:10 - Possibly undefined array offset ''host'' is risky given expected type 'array-key'. Consider using isset beforehand.

INFO: MixedArgument - 59:10 - Argument 1 of echo cannot be mixed, expecting string

from psalm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.