Comments (3)
indeed. Hence why psalm shouldn't ask me to add #[\Override]
hence my bug report.
from psalm.
I found these snippets:
https://psalm.dev/r/70ba038824
<?php
trait Foo
{
private function inTrait(): void { echo "foobar\n"; }
}
class A {
use Foo;
public function bar(): void {
$this->inTrait();
}
}
class B extends A {
use Foo;
function baz(): void
{
$this->inTrait();
}
}
$b = new B();
$b->baz();
Psalm output (using commit 16b24bd):
ERROR: MissingOverrideAttribute - 5:5 - Method inTrait should have the "Override" attribute
from psalm.
- Private methods of a parent class do not satisfy #[\Override], because it's not part of the externally visible API.
from psalm.
Related Issues (20)
- Overlooks UndefinedPropertyFetch in untyped inline function HOT 1
- False positive UnusedMethodCall for ReflectionProperty::setAccessible HOT 3
- Fatal error since PHP 8.3.9+ HOT 7
- Report possible bug if variable is type `0|1|bool` and it's compared strictly with 1, true, false HOT 1
- [New Feature] Not using Docblock parameter types HOT 1
- ./vendor/bin/psalm --init PHP Fatal error: Uncaught Psalm\Exception\ConfigException: Config not found for path HOT 9
- Malformed JSON output due to erroneous UTF-8 character splitting HOT 1
- `MixedArgumentTypeCoercion` when try to use defined array type with ... HOT 1
- Psalm assumes `callable-string` is always lowercase HOT 1
- Incorrect RedundantCondition with `class-string<Foo>` and instanceof HOT 1
- InvalidArgument: 'expects a public static callable, but a non-static callable provided' HOT 1
- `Dom\XMLDocument` is unimplemented HOT 2
- "false cannot be cast to int" with truthy-string (Can't repro in sandbox) HOT 1
- Invalid type detect after AND condition HOT 1
- clearstatcache 2nd argument is unused if 1st arg is not true should report error HOT 1
- Incorrect type detection when null-safe operator usage HOT 1
- Possible to improve/preserve `non-empty-string` type when `\substr(T, 0, positive-int)` is used? HOT 1
- Memory issue running Psalm Github Action HOT 5
- Invalid namespace for a declared nested type in an array type HOT 2
- Missing TaintedCallable for 4 core generic functions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psalm.