Comments (3)
I found these snippets:
https://psalm.dev/r/1245f7d7f6
<?php
/**
* @template TKey of array-key
* @template TValue
*/
interface Arrayable
{
/**
* Get the instance as an array.
*
* @return array<TKey, TValue>
*/
public function toArray();
}
class Arr
{
/**
* Run a map over each of the items in the array.
*
* @param array $array
* @param callable $callback
* @return array
*/
public static function map(array $array, callable $callback)
{
$keys = array_keys($array);
try {
$items = array_map($callback, $array, $keys);
} catch (ArgumentCountError) {
$items = array_map($callback, $array);
}
return array_combine($keys, $items);
}
}
/**
* @template TKey of array-key
*
* @template-covariant TValue
*/
class Collection
{
/**
* The items contained in the collection.
*
* @var array<TKey, TValue>
*/
protected $items = [];
/**
* Create a new collection.
*
* @param Arrayable<TKey, TValue>|iterable<TKey, TValue>|null $items
* @return void
*/
public function __construct($items = [])
{
$this->items = $this->getArrayableItems($items);
}
/**
* Merge the collection with the given items.
*
* @param Arrayable<TKey, TValue>|iterable<TKey, TValue> $items
* @return static
*/
public function merge($items)
{
return new static(array_merge($this->items, $this->getArrayableItems($items)));
}
/**
* Run a map over each of the items.
*
* @template TMapValue
*
* @param callable(TValue, TKey): TMapValue $callback
* @return static<TKey, TMapValue>
*/
public function map(callable $callback)
{
return new static(Arr::map($this->items, $callback));
}
/**
* Results array of items from Collection or Arrayable.
*
* @param mixed $items
* @return array<TKey, TValue>
*/
protected function getArrayableItems($items)
{
if (is_array($items)) {
return $items;
}
return (array) $items;
}
}
$suffixHeaders = ['foo', 'bar'];
(new Collection())
->merge($suffixHeaders)
->map(fn (string $header) => ucfirst($header));
Psalm output (using commit ef3b018):
ERROR: InvalidArgument - 107:13 - Argument 1 of Collection::merge expects Arrayable<never, never>|iterable<never, never>, but list{'foo', 'bar'} provided
ERROR: ReservedWord - 108:15 - Parameter cannot be never
ERROR: InvalidTemplateParam - 68:16 - Template param TValue of Collection is marked covariant and cannot be used here
ERROR: UnsafeInstantiation - 73:16 - Cannot safely instantiate class Collection with "new static" as its constructor might change in child classes
ERROR: InvalidTemplateParam - 81:16 - Template param TValue of Collection is marked covariant and cannot be used here
ERROR: UnsafeInstantiation - 86:16 - Cannot safely instantiate class Collection with "new static" as its constructor might change in child classes
from psalm.
but is this mandtory now?
It basically always was. Perhaps a new release got a bit more strict (like not allowing to pass never
as argument), but Psalm always required a docblock override for generics with default constructor parameters.
from psalm.
Yes. And also there seems to be a bit of a recurring antipattern in our codebase.
collect()->merge($wellDefinedArray)
cannot work but collect($wellDefinedArray)
is just fine.
I'll just close this and hammer the issues out.
from psalm.
Related Issues (20)
- Unexpected MixedReturnStatement HOT 1
- Non-existing @psalm annotation shouldn't break otherwise valid docblock HOT 1
- False UnusedFunctionCall error HOT 3
- `@psalm-assert-if-true` causes psalm to think function can't return `false`? HOT 9
- False-positive `MixedArgument` (assignment in `if` clause) HOT 1
- Missing class constant not detected by any error level HOT 1
- jsonSerialize triggers PossiblyUnusedMethod even when json_encode is called HOT 1
- Covariant template not supported call-site HOT 1
- Code comment that asserts a variable satisfies a type (@psalm-satisfies) HOT 2
- Allow suppressing a psalm issue for a single Attribute or parameter HOT 1
- "Could not get class storage for X"
- Taint analysis: allow marking properties as taint sources? HOT 2
- `non-empty-string` false positive detection HOT 4
- Return type: subtype of type HOT 1
- Inherit `value-of` class constant (static behavior) HOT 1
- @psalm-require-extends does not consider generics HOT 1
- Bug when using "@template" HOT 1
- Non-null template value HOT 1
- False-positive `ReservedWord` issue HOT 3
- Docbloc: callable() is not a valid method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psalm.