Git Product home page Git Product logo

Comments (3)

psalm-github-bot avatar psalm-github-bot commented on June 17, 2024

I found these snippets:

https://psalm.dev/r/1245f7d7f6
<?php

/**
 * @template TKey of array-key
 * @template TValue
 */
interface Arrayable
{
    /**
     * Get the instance as an array.
     *
     * @return array<TKey, TValue>
     */
    public function toArray();
}

class Arr
{
    /**
     * Run a map over each of the items in the array.
     *
     * @param  array  $array
     * @param  callable  $callback
     * @return array
     */
    public static function map(array $array, callable $callback)
    {
        $keys = array_keys($array);

        try {
            $items = array_map($callback, $array, $keys);
        } catch (ArgumentCountError) {
            $items = array_map($callback, $array);
        }

        return array_combine($keys, $items);
    }
}

/**
 * @template TKey of array-key
 *
 * @template-covariant TValue
 */
class Collection
{
    /**
     * The items contained in the collection.
     *
     * @var array<TKey, TValue>
     */
    protected $items = [];
    
     /**
     * Create a new collection.
     *
     * @param  Arrayable<TKey, TValue>|iterable<TKey, TValue>|null  $items
     * @return void
     */
    public function __construct($items = [])
    {
        $this->items = $this->getArrayableItems($items);
    }
    
    /**
     * Merge the collection with the given items.
     *
     * @param  Arrayable<TKey, TValue>|iterable<TKey, TValue>  $items
     * @return static
     */
    public function merge($items)
    {
        return new static(array_merge($this->items, $this->getArrayableItems($items)));
    }
    
    /**
     * Run a map over each of the items.
     *
     * @template TMapValue
     *
     * @param  callable(TValue, TKey): TMapValue  $callback
     * @return static<TKey, TMapValue>
     */
    public function map(callable $callback)
    {
        return new static(Arr::map($this->items, $callback));
    }
    
   /**
     * Results array of items from Collection or Arrayable.
     *
     * @param  mixed  $items
     * @return array<TKey, TValue>
     */
    protected function getArrayableItems($items)
    {
        if (is_array($items)) {
            return $items;
        }
        
        return (array) $items;
    }
}

$suffixHeaders = ['foo', 'bar'];
(new Collection())
    ->merge($suffixHeaders)
    ->map(fn (string $header) => ucfirst($header));
Psalm output (using commit ef3b018):

ERROR: InvalidArgument - 107:13 - Argument 1 of Collection::merge expects Arrayable<never, never>|iterable<never, never>, but list{'foo', 'bar'} provided

ERROR: ReservedWord - 108:15 - Parameter cannot be never

ERROR: InvalidTemplateParam - 68:16 - Template param TValue of Collection is marked covariant and cannot be used here

ERROR: UnsafeInstantiation - 73:16 - Cannot safely instantiate class Collection with "new static" as its constructor might change in child classes

ERROR: InvalidTemplateParam - 81:16 - Template param TValue of Collection is marked covariant and cannot be used here

ERROR: UnsafeInstantiation - 86:16 - Cannot safely instantiate class Collection with "new static" as its constructor might change in child classes

from psalm.

weirdan avatar weirdan commented on June 17, 2024

but is this mandtory now?

It basically always was. Perhaps a new release got a bit more strict (like not allowing to pass never as argument), but Psalm always required a docblock override for generics with default constructor parameters.

from psalm.

paali avatar paali commented on June 17, 2024

Yes. And also there seems to be a bit of a recurring antipattern in our codebase.
collect()->merge($wellDefinedArray) cannot work but collect($wellDefinedArray) is just fine.

I'll just close this and hammer the issues out.

from psalm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.