Comments (6)
psalm-github-bot
commented on September 26, 2024
Hey @TheDevick, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.
from psalm.
TheDevick
commented on September 26, 2024
Hey @TheDevick, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.
https://psalm.dev/r/1486877b8b
from psalm.
psalm-github-bot
commented on September 26, 2024
I found these snippets:
https://psalm.dev/r/1486877b8b
<?php
class Decimal implements \Stringable
{
/**
* @param numeric-string $value
*/
final private function __construct(
private string $value
) {
}
public static function create(string $value): static
{
if (!is_numeric($value)) {
throw new \Exception(sprintf('The decimal value "%s" is non-numeric', $value));
}
return new static($value);
}
public function add(Decimal $value, ?int $scale = null): static
{
return static::create(bcadd($this, $value, $scale));
}
public function subtract(Decimal $value, ?int $scale = null): static
{
return static::create(bcsub($this, $value, $scale));
}
public function multiply(Decimal $value, ?int $scale = null): static
{
return static::create(bcmul($this, $value, $scale));
}
public function divide(Decimal $value, ?int $scale = null): static
{
return static::create(bcdiv($this, $value, $scale));
}
/**
* @return numeric-string
*/
public function __toString(): string
{
return $this->value;
}
}
class Kilowatt extends Decimal
{
public static function createFromWatt(Watt $watt, ?int $scale = null): self
{
$thousand = Decimal::create('1000');
return self::create($watt->divide($thousand, $scale));
}
}
class Watt extends Decimal
{
public static function createFromKilowatt(Kilowatt $kilowatt, ?int $scale = null): self
{
$thousand = Decimal::create('1000');
return self::create($kilowatt->multiply($thousand, $scale));
}
}Psalm output (using commit ef3b018):
ERROR: ImplicitToStringCast - 24:37 - Argument 1 of bcadd expects numeric-string, but Decimal&static provided with a __toString method
ERROR: ImplicitToStringCast - 24:44 - Argument 2 of bcadd expects numeric-string, but Decimal provided with a __toString method
ERROR: ImplicitToStringCast - 29:37 - Argument 1 of bcsub expects numeric-string, but Decimal&static provided with a __toString method
ERROR: ImplicitToStringCast - 29:44 - Argument 2 of bcsub expects numeric-string, but Decimal provided with a __toString method
ERROR: ImplicitToStringCast - 34:37 - Argument 1 of bcmul expects numeric-string, but Decimal&static provided with a __toString method
ERROR: ImplicitToStringCast - 34:44 - Argument 2 of bcmul expects numeric-string, but Decimal provided with a __toString method
ERROR: ImplicitToStringCast - 39:37 - Argument 1 of bcdiv expects numeric-string, but Decimal&static provided with a __toString method
ERROR: ImplicitToStringCast - 39:44 - Argument 2 of bcdiv expects numeric-string, but Decimal provided with a __toString method
ERROR: ImplicitToStringCast - 57:29 - Argument 1 of Kilowatt::create expects string, but Decimal&Watt provided with a __toString method
INFO: LessSpecificReturnStatement - 57:16 - The type 'Decimal&static' is more general than the declared return type 'Kilowatt' for Kilowatt::createFromWatt
INFO: MoreSpecificReturnType - 53:76 - The declared return type 'Kilowatt' for Kilowatt::createFromWatt is more specific than the inferred return type 'Decimal&static'
ERROR: ImplicitToStringCast - 67:29 - Argument 1 of Watt::create expects string, but Decimal&Kilowatt provided with a __toString method
INFO: LessSpecificReturnStatement - 67:16 - The type 'Decimal&static' is more general than the declared return type 'Watt' for Watt::createFromKilowatt
INFO: MoreSpecificReturnType - 63:88 - The declared return type 'Watt' for Watt::createFromKilowatt is more specific than the inferred return type 'Decimal&static'
from psalm.
TheDevick
commented on September 26, 2024
I don't know why it's giving so much errors. Maybe because of the bc extension. But in my project, it just shows the errors I mentioned
from psalm.
TheDevick
commented on September 26, 2024
Hey! Just wanted to metion that I did some tests and concluded that:
$watt = Watt::create('1.0') // This IS returning an Watt object, instead of the referred psalm return type Decimal&static;from psalm.
TheDevick
commented on September 26, 2024
Founded a solution. Add the following @return annotation to the Decimal::create() static method:
/**
* @return static
*/
public static function create(string $value): static
{
if (!is_numeric($value)) {
throw new InvalidDecimalValueException(sprintf('The decimal value "%s" is non-numeric', $value));
}
return new static($value);
}Is it a bug? Because I'm already telling the PHP itself that the method returns static!
from psalm.
Related Issues (20)
- Unexpected MixedReturnStatement HOT 1
- Non-existing @psalm annotation shouldn't break otherwise valid docblock HOT 1
- False UnusedFunctionCall error HOT 3
- `@psalm-assert-if-true` causes psalm to think function can't return `false`? HOT 9
- False-positive `MixedArgument` (assignment in `if` clause) HOT 1
- Missing class constant not detected by any error level HOT 1
- jsonSerialize triggers PossiblyUnusedMethod even when json_encode is called HOT 1
- Covariant template not supported call-site HOT 1
- Code comment that asserts a variable satisfies a type (@psalm-satisfies) HOT 2
- Allow suppressing a psalm issue for a single Attribute or parameter HOT 1
- "Could not get class storage for X" HOT 1
- Taint analysis: allow marking properties as taint sources? HOT 2
- `non-empty-string` false positive detection HOT 4
- Return type: subtype of type HOT 1
- Inherit `value-of` class constant (static behavior) HOT 1
- @psalm-require-extends does not consider generics HOT 1
- Bug when using "@template" HOT 2
- Non-null template value HOT 1
- False-positive `ReservedWord` issue HOT 3
- Docbloc: callable() is not a valid method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psalm.