Psalm 6: deprecate getSingleAtomic() about psalm HOT 5 OPEN

Hey @kkmuffme, can you reproduce the issue on https://psalm.dev ?

from psalm.

+1 on this, never really liked the naming of that method, it's too confusing

from psalm.

I got bitten a few times on this also. However, looping over a known single result array is really annoying IMHO (and arbitrarily access the first element of a possibly empty array is worse). I'd prefer deprecating or renaming isSingle to replace it with a correct check for single Atomic.

But seeing as you two contribute a loot more than I do these days (or months :D), I'll let you be the judge of what needs to be done!

from psalm.

Well the actual logic itself of the method may be sometimes useful, but the current name is positively awful, and I can't think of a proper one out of the box (isSingleAtomicOrSingleLiteralSupertype? can't really think of anything).

Though a proper isSingleAtomic method should still be provided, simply doing count($this->types) === 1, and getSingleAtomic is also useful in this sense, I see no reason to remove it.

from psalm.

I think "isSingle" is used more often than "getSingleAtomic" so deprecating that is less work :D

from psalm.