Git Product home page Git Product logo

Comments (10)

mutewinter avatar mutewinter commented on August 15, 2024

Found this same problem with jsl. I updated the code on line 71 as follows to fix the problem:

let makeprg = "jsl" . jslconf . " -nologo -nofilelisting -nosummary -nocontext -process ".expand('%:p')

I removed shellescape and changed % to %:p.

from syntastic.

M4T1A5 avatar M4T1A5 commented on August 15, 2024

I believe this exact problem also occurs in the html.vim file too (and i find it odd that these problems have not been fixed yet as validating HTML simply does not work on windows atm)

from syntastic.

scrooloose avatar scrooloose commented on August 15, 2024

@M4T1A5 the reason these problems have not been fixed is because I currently dont have access to a windows box, and I want to get in and find out what is really going on. Removing the shellescape() call seems like it is fixing the symptom rather than the problem.

@mutewinter can you stick in an 'echo makeprg' and see what is actually getting set as the makeprg (without your custom mods)?

If this doesnt offer any clues then it could be an idea to set shellescape on windows and see if that works - if this turns out to be needed for windows then ill write a SyntasticShellEsc() function to set it on and off when doing the shellescape()

from syntastic.

mutewinter avatar mutewinter commented on August 15, 2024

This problem seems to be gone on the latest version of Vim that I'm using. I'm currently using Wu Yongwei's pre-compiled gVim 7.3.333.

I'm also using the latest Syntastic, which may have fixed the issue as well.

Feel free to mark this as closed.

from syntastic.

darcyparker avatar darcyparker commented on August 15, 2024

This problem seems to persist in the latest version for html.vim.
Thanks to the hints above, I fixed the issue by change " to ' and ' to " for win32 and win64

if has('win32') || has('win64')
    let makeprg='tidy '.encopt.' --new-blocklevel-tags "section, article, aside, hgroup, header, footer, nav, figure, figcaption" --new-inline-tags "video, audio, embed, mark, progress, meter, time, ruby, rt, rp, canvas, command, details, datalist" --new-empty-tags "wbr, keygen" -e '.shellescape(expand("%"))
else
    let makeprg="tidy ".encopt." --new-blocklevel-tags 'section, article, aside, hgroup, header, footer, nav, figure, figcaption' --new-inline-tags 'video, audio, embed, mark, progress, meter, time, ruby, rt, rp, canvas, command, details, datalist' --new-empty-tags 'wbr, keygen' -e ".shellescape(expand('%'))." 2>&1"
endif

from syntastic.

darcyparker avatar darcyparker commented on August 15, 2024

Thanks for merging in my pull request with the cleaner solution. (BTW: It was my first pull request ever... so it feels good to have figured it out and get it accepted.) 469e4ef

This issue appears resolved for xhtml.vim (as @mutewinter mentioned above) and for html.vim (which was fixed in the commit mentioned above.)

from syntastic.

scrooloose avatar scrooloose commented on August 15, 2024

@darcyparker no worries - you definitely made it easy for me to accept :)

If anyone has any further issues with this then just comment back here and ill reopen.

from syntastic.

peroo avatar peroo commented on August 15, 2024

Having problems with this on Windows with latest build of Syntastic and a fairly recent GVim, specifically trying to process javascript with jshint. I debugged a bit and the resulting makeprg is jshint '<filename>', which command.exe doesn't parse. Ended up fixing by hardcoding double quotes, but obviously that's not a great solution.

from syntastic.

scrooloose avatar scrooloose commented on August 15, 2024

hmm, it is using vims built in shellescape() for the filename - which is why there are quotes around it.

According to :h shellescape() this should be using double quotes on windows.... Any idea why its not?

from syntastic.

peroo avatar peroo commented on August 15, 2024

Turns out I had shellslash set, which among other things causes shellescape to use single quotes for some reason. Turning it off solved the problem. Thanks for the speedy response, and apologies for the confusion.

from syntastic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.