RepeatLast should allow to specify whether to do Find or Replace (was Crtl-G default behaviour) about ne HOT 21 CLOSED

There are too many config options/flags already, and adding new commands is a very large hammer for such a small (thumb)nail. But I think your original idea is correct -- that it should be as easy to do a RepeatLastFind or RepeatLastReplace as it is to do a RepeatLast. RepeatLast is certainly useful, but it is also quirky enough to constitute a barrier-to-entry for new users.

After having thought about it a while, I think the right answer is to add an optional parameter to RepeatLast, which would be [F|Find|R|Replace]. The default action would be as it is now -- whichever was done most recently -- but you could map a key to "RepeatLast Find" to get the behaviour you expect. I'll take a look to be sure, but this should take a minimal amount of code, doesn't break existing behaviour, and fills a reasonable expectation. (Also, not easily done with macros; I tried. Ugh.)

from ne.

By the way, very excited about the coming release!!

from ne.

Which branch did you pull from? I think we have recently committed some bad code somewhere, and we're trying to sort things out right now. So sorry.

from ne.

Sorry guys this must be me. I'm doing experiments in the master branch, which is of course criminal...

from ne.

I see, but there's a logic: CTRL-G is "Repeat Last". If you search and replaced a single item, but you want to replace some more, just hit CTRL-G. I think in fact people is quite used to that by now...

from ne.

But when you enter replace, you enter into a whole different level of UI. When you exit that, it is strange (and destructive!) to have Ctrl-G to do a replace outside of the replace UI.

Maybe could you add a Find Last command?? Then I'll change my Ctrl-G locally. :-)

from ne.

Would you prefer if I open a new Issue on the request for a Find Last command??

from ne.

If you've been doing Replace, and you want go back to doing Find, why not just do "^F<Enter>"? The Find prompt defaults to the prior Find string. There's some value in keeping the number of commands in the "find and replace" suite small. The bar for adding new commands needs to be pretty high, and I'm not sure that FindLast would meet that test when Find basically does it already.

from ne.

I don't like for a replace to happen when I want to repeat a find. Maybe I can just redefine Ctrl-G as Ctrl-F ?

If you want to keep the number of commands small, I think a Repeat Last Find would be more useful than a Repeat Last Find/Replace.

Or, can I request a configuration option to change Repeat Last to not include Replace??

from ne.

Thank you for your thoughtful consideration! I will surely use this a lot.

from ne.

@pepa65 There is now a "repeatlast" branch. Please check it out and see what you think.

from ne.

Super! Just works (tm)..! Thanks a lot.

from ne.

Thank you for your thoughtful consideration! I will surely use this a lot.

from ne.

I don't know what's wrong with my system suddenly, no matter which branch or version I build, I can make it segfault by editing an existing file, and then: Enter Up 's'

from ne.

Any branch -- at least I my (file?)system is not getting hosed (or I going crazy or incompetent...)!
I'll wait until the dust clears.

from ne.

Does the master branch not segfault at your end??
ne README.md then Enter Up Space

from ne.

No, it doesn't. Make sure you're starting from a really clean tree. There were some changes in cc options that might be hurting you if you have leftover .o files, which a git checkout wouldn't fix:

make clean
cd doc && make clean
cd ../src && make clean
cd ..```

from ne.

That didn't do the trick... Now I've done cd ..; rm -rf ne; git clone https://github.com/vigna/ne; cd ne; make build; sudo make install; src/ne README.md and then get a segfault after Enter Up Space.

from ne.

Fixed!

from ne.

Master branch is good here now. The repeatlast branch still segfaults the same way.

from ne.

The repeatlast branch is now also working!

from ne.