auto-save workflow state about django-fsm HOT 8 CLOSED

Our solution was a post transition signal to save the new state upon successful state change:

from django_fsm.signals import post_transition

@receiver(post_transition, sender=models.MyModel)
def save_new_workflow_state(sender, instance, name, source, target, **kwargs):
    """ Save the new workflow state following successful django_fsm transition. """

    if source != target:
        instance.save()

from django-fsm.

Yep, it was removed in 2014 with django-fsm 2.0 release.

The recommended way for today is to switch to django-viewflow==2.0.0a and explicitly define desired behavior with .on_success decorator - https://docs-next.viewflow.io/fsm/models.html

from django-fsm.

What is the recommandation if we want to stick with django-fsm package?

from django-fsm.

@xavella thanks for sharing! Is there a way to write this once for all models?
I can already see a new developer joining our codebase, adding a new Django Model and asking "why my model is not saved"? :)

from django-fsm.

I wouldn't take that approach as it would also apply to the admin models, which I don't see any reason to restrict track. How many models?

from django-fsm.

I'm not sure to understand the issue with admin models, as only my custom models have FSMField and transitions configured (except if a package is using django-fsm behind the scene ?).

Lots of models (more than 10) will need transitions. If I can do it, I'd like to avoid the manual step to add a signal for each of them, as it could be error-prone, and it's not DRY.

from django-fsm.

I would do this long-hand, not sure how to abstract the signal but maybe there is a way.

from django-fsm.

it seems ok following these steps:

• removing the sender parameter from within the decorator (means all senders are accepted)
• moving the signal to signals.py into my app
• importing it using the ready() method

from django-fsm.