Comments (2)
One more bug:
Consider the following chain of events:
- Page removed (Delete record written)
- Page resurrected
- Page updated (Update record written)
When this is replayed from the recovery file, the logic will first update the page (as page updates will be applied first) then the page gets deleted.
A potential fix is in ReadAllRecords
when an update record is discovered, it should drop the page index from DeletedPageIndexes
again, analog to dropping earlier Update records after a Delete record is encountered.
from datatanker.
Great contribution as always!
RecoveryFile really lacked tests. Thank you for the first one! I hope this function works properly now.
from datatanker.
Related Issues (11)
- Storing multiplex indices/values in the same storage HOT 1
- Trying to add 1-n relation HOT 1
- Disposing recoveryFile when a member variable HOT 2
- pagemap size HOT 2
- dose this support auto compress ?
- Not an issue
- GREAT HOT 2
- Incorrect uses of CompareTo HOT 1
- FSPageManager default buffering considered harmful HOT 1
- Consider adding a secondary page cache
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datatanker.