Git Product home page Git Product logo

Comments (12)

victorgarciaesgi avatar victorgarciaesgi commented on June 15, 2024 3

Done!

from vue-chart-3.

victorgarciaesgi avatar victorgarciaesgi commented on June 15, 2024 2

Great news guys, 3.0.5 released and I found the bug! :D

It was from me, it came from a piece of code I borrowed from vue-chartjs

af4d6b3#diff-af796a020e973df5f3ef424841c9f55fdb45d09ffac0ca4715fc0692f257b2e3R122

from vue-chart-3.

victorgarciaesgi avatar victorgarciaesgi commented on June 15, 2024 1

@dylan-george-field Yeah it's strange because all the chartData object is reactive so it seems to be a Chart.js bug, I will look into this

from vue-chart-3.

BITRU avatar BITRU commented on June 15, 2024 1

Also have problem with legend : true when onClick used custom function.
I think that answer in chartjs doc https://www.chartjs.org/docs/latest/configuration/legend.html

If options: { plugins: { legend: { onClick: newLegendClickHandler...
need to const defaultLegendClickHandler = Chart.defaults.plugins.legend.onClick;

So, default update chart can be trigered. Will that help on fixing issue?

from vue-chart-3.

victorgarciaesgi avatar victorgarciaesgi commented on June 15, 2024 1

Hi all! Sorry for the lack of updates i try to be present as possible. I didn't know why it didn't update, the watcher corretly triggers when hidden is modified so I though that was on Chart.js side

from vue-chart-3.

germain-receeve avatar germain-receeve commented on June 15, 2024

Hey @victorgarciaesgi 👋
Thanks for creating this library, it's been a life saviour for us to migrate to Chart.js 3 on Vue 2.
Sadly, we also faced the same problem since we are using custom legends outside chart.js. We toggle the visibility of dataset using the hidden property and it is not reactive :(

Any chance you have some time to look into it ? 🙏

from vue-chart-3.

germain-receeve avatar germain-receeve commented on June 15, 2024

Amazing, thank you so much!!

from vue-chart-3.

victorgarciaesgi avatar victorgarciaesgi commented on June 15, 2024

Keep me updated! I'll wait for @dylan-george-field answer too before closing because I kind of abandonned him :(

from vue-chart-3.

germain-receeve avatar germain-receeve commented on June 15, 2024

Oh I just noticed that you only released it for 3.x, can you also make the 2.0.5 available so I can try it out in our Vue 2 app? :) @victorgarciaesgi

from vue-chart-3.

victorgarciaesgi avatar victorgarciaesgi commented on June 15, 2024

Oh yeah sorry, I will release it right now :)

from vue-chart-3.

germain-receeve avatar germain-receeve commented on June 15, 2024

Just tried it out, works perfectly now with 2.0.5.
Thanks once again and have a great evening! ✨

from vue-chart-3.

BITRU avatar BITRU commented on June 15, 2024

Wow, that was quick and assomme. Thank you so much!

from vue-chart-3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.