Git Product home page Git Product logo

Comments (4)

vesse avatar vesse commented on July 18, 2024

So this type of error should be handled as a login failure instead of an error? If so I'll make the change you suggested.

from passport-ldapauth.

nmanchovski avatar nmanchovski commented on July 18, 2024

Well I haven't gone deeper in ldapjs on how it looks up for the user, but this is the error that I receive when I enter non existing user. Since this is an unhandled exception my application exits. I can handle this somehow with some middleware, but I have found that if I handle this error as in the above example it reports the error very nicely with the rest of the passport library. The stack trace shows that this particular exception is thrown in ldapjs/lib/client.js:851 My setup looks like
server: {
url: 'ldap://url:port',
adminDn: 'user',
adminPassword: 'pass',
searchBase: 'OU=users,O=domain',
searchFilter: '(uid={{username}})',
searchAttributes: ['name', 'mail'],
}

from passport-ldapauth.

vesse avatar vesse commented on July 18, 2024

OK, just wanted to confirm. I'll fix it right away.

from passport-ldapauth.

vesse avatar vesse commented on July 18, 2024

Published version 0.1.2. Please check if it works for you now.

from passport-ldapauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.