Unhandled error event about passport-ldapauth HOT 9 CLOSED

I believe this should now be fixed with 1.0.0 of passport-ldapauth since ldapauth-fork now re-emits ldapjs errors.

from passport-ldapauth.

I need to check this when I have time. The ldapjs clients are in vesse/node-ldapauth-fork which this passport wrapper uses, and they do not have the listener attached. It's easy to add the listeners, but I don't know yet at which point this error really happens and thus what could be done when it happens.

from passport-ldapauth.

The stacktrace provided by Node is awful from this point of view, no way to easily find out where the request is initiated in any of 3-4 modules. Anyhow your comment is helpful, I will investigate further in the other modules and open issues there as appropriate.

from passport-ldapauth.

Oh shoot, looks like still problems with ldapjs 1.0.0

from passport-ldapauth.

I'm facing this issue as well if the LDAP server is unreachable. Any ETA for a fix? :)

from passport-ldapauth.

also bumping up against this

from passport-ldapauth.

Seems like the heart of this is with ldapauth-fork, vesse/node-ldapauth-fork#41, if they accept that pull request then it should be trivial to fix the problem in passport-lpapauth

from passport-ldapauth.

Here's a version of passport-ldapauth which illustrates how by pulling in the the fix for node-ldapauth-fork we could patch passport-ldapauth. I didn't make this an official pull request because the pull request for node-ldapauth-fork#41 hasn't been accepted yet, but if/when that gets accepted and merged into the main ldapauth repo you should be able to do something like this

chriswininger@9064385

It works as a temporary work around for us anyways

from passport-ldapauth.

That's great! Thanks

from passport-ldapauth.