Git Product home page Git Product logo

Comments (10)

random6886 avatar random6886 commented on July 18, 2024

I should also note that I am using the npm install passport-ldapauth, so I am using the current version. I noticed in your ldapauth-fork that you had tried to correct this issue.

from passport-ldapauth.

vesse avatar vesse commented on July 18, 2024

This issue comes from ldapjs/node-ldapjs#256, encrypted connections work fine with Node.js v0.10 (I told this to mr. Carpani in response to his email but he did not include the reason to the reply in the question above).

I'm going to see if new version of ldapjs will be released soonish, I prefer not to depend on unreleased versions (one reason being that I know the library is used in environments that have restricted Internet access and installing from GitHub would not work).

from passport-ldapauth.

random6886 avatar random6886 commented on July 18, 2024

Ah I see. I appreciate such a quick reply back! I suppose I just got really confused when the version was first: [email protected] and then after I apply that pull, it's still that same version. Furthermore, several of the sub-modules have pretty old versions it appears ex: [email protected] -> [email protected].

Appreciate the quick response!

from passport-ldapauth.

vesse avatar vesse commented on July 18, 2024

Yeah, the versions come from ldapjs package.json when you install from GitHub, so it might seem confusing. In reality there has been quite a lot of changes since the release of [email protected], including eg. bunyan dependency upgrade.

But good news is that you should be able to work around this. If you add ldapjs (from GitHub) to the package.json of your project, ldapauth-fork and therefore passport-ldapauth should use that one instead, ie:

{
  ...
  "dependencies": {
    "ldapjs": "mcavage/node-ldapjs",
    "passport-ldapauth": "0.3.0",
    ...
  }
}

from passport-ldapauth.

csulok avatar csulok commented on July 18, 2024

Thanks for the suggestion on adding mcavage/node-ldapjs as a dep. You might want to consider doing that in passport-ldapauth's package.json too, since the author of node-ldapjs doesn't seem too eager to fix things there (looking at the last comments being 17 days old, the patch more than a month now).

from passport-ldapauth.

ricardohbin avatar ricardohbin commented on July 18, 2024

As I told in ldapjs/node-ldapjs#258, we can bypass the dtracer exceptions, since it is an optional module.

npm install passport-ldapauth --no-optional

from passport-ldapauth.

axkibe avatar axkibe commented on July 18, 2024

Thank you a lot for the workaround! With this is works...

from passport-ldapauth.

aroramayur avatar aroramayur commented on July 18, 2024

Any chance of a newer version ( with this fix) being released soon...can't depend on an unreleased version.

from passport-ldapauth.

vesse avatar vesse commented on July 18, 2024

@mayur-arora well there has not been a new release of ldapjs so me adding this unreleased dependency to this module kinda makes you use an unreleased version as well :) And I too don't want to publish a module that depends on an unreleased version, but if someone wants to work around this issue by using the unreleased version of ldapjs it is entirely possible as described above.

from passport-ldapauth.

aroramayur avatar aroramayur commented on July 18, 2024

@vesse Thanks . Just want to confirm. I was actually referring to the fix for ldapjs/node-ldapjs#256

from passport-ldapauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.