Git Product home page Git Product logo

Comments (3)

vesse avatar vesse commented on July 18, 2024

Your problem description and code example do not provide anything to work with. However I'm pretty confident the problem is not in this module as errors received from ldapauth-fork will cause either a fail or an error. ldapauth-fork also returns errors returned by ldapjs. Also, I have not had problems with non-existing users.

from passport-ldapauth.

wbruno avatar wbruno commented on July 18, 2024

Sorry, for the lack of information
Here is what I was thinking:

var expect = require('chai').expect;
//...
    it("should return unauthorized with invalid credentials", function(cb) {
      request(expressapp)
        .post('/login')
        .send({username: 'valid', password: 'invvalid'})
        .expect(401)
        .end(function(err, res){
          expect(err).to.be.equal('Invalid username/password');
          cb();
        });
    });

The err returned is null instead of Invalid username/password.
Is this right ?

from passport-ldapauth.

vesse avatar vesse commented on July 18, 2024

Yes that is correct. As you can see the test sends a HTTP request like your web browser. It expects the Express server to respond with HTTP status 401 in case of incorrect credentials which it does. If the server would reply eg. HTTP 200 then there would be an error.

from passport-ldapauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.