according to <a href="https://winprotocoldoc.blob.core.windows.net/productionwindowsar

It seems that PR had two issues: it was quite big, trying to t

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

BUG: invalid implementation of NTOWFv2 hashing about cntlm HOT 4 CLOSED

versat commented on July 23, 2024

BUG: invalid implementation of NTOWFv2 hashing

from cntlm.

Comments (4)

jschwartzenberg commented on July 23, 2024 1

It seems that PR had two issues:

it was quite big, trying to tackle multiple problems
it broke authentication in some environments

My proposal would be to have a PR with just this fix and to introduce the structs refactoring in a separate PR. Then both can be tested independently for compatibility with different implementations. As they might touch the same code, you may have to provide one after the other. Smaller PRs with independent fixes have a much higher chance than getting merged than large PRs.

from cntlm.

fralken commented on July 23, 2024

Thanks @arminfelder. Can you provide a PR with just the fix (how to retrieve the userDom and use it instead of target), and after another PR with the code refactoring?

from cntlm.

fralken commented on July 23, 2024

Indeed the equivalent of NTOWFv2 in cntlm is correct, because it is passntlm2 that is computed by this function:

cntlm/ntlm.c

Lines 200 to 224 in 83f7c54

 char *ntlm2_hash_password(const char *username, const char *domain, const char *password) { 

 char *tmp; 

 char *buf; 

 char *passnt; 

 char *passnt2; 

 int len; 

 passnt = ntlm_hash_nt_password(password); 

 const size_t buf_len = strlen(username) + strlen(domain) + 1; 

 buf = zmalloc(buf_len); 

 strlcat(buf, username, buf_len); 

 strlcat(buf, domain, buf_len); 

 uppercase(buf); 

 len = unicode(&tmp, buf); 

 passnt2 = zmalloc(16 + 1); 

 hmac_md5(passnt, 16, tmp, len, passnt2); 

 free(passnt); 

 free(tmp); 

 free(buf); 

 return passnt2; 

 }

from cntlm.

fralken commented on July 23, 2024

It turns out that the actual issue was that the authentication message is not complete when the target info is missing from the challenge. This is fixed with commit 533f137.

from cntlm.

Recommend Projects

BUG: invalid implementation of NTOWFv2 hashing about cntlm HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	char ntlm2_hash_password(const char username, const char domain, const char password) {
	char *tmp;
	char *buf;
	char *passnt;
	char *passnt2;
	int len;

	passnt = ntlm_hash_nt_password(password);

	const size_t buf_len = strlen(username) + strlen(domain) + 1;
	buf = zmalloc(buf_len);
	strlcat(buf, username, buf_len);
	strlcat(buf, domain, buf_len);
	uppercase(buf);
	len = unicode(&tmp, buf);

	passnt2 = zmalloc(16 + 1);
	hmac_md5(passnt, 16, tmp, len, passnt2);

	free(passnt);
	free(tmp);
	free(buf);

	return passnt2;
	}