Comments (4)
rizdaprasetya
commented on August 22, 2024
Actually the credit_card.authentication API wise accept both string & boolean, to maximize compatibility. The quick solution will be to change the type to string, which should be safe for both:
Line 63 in 9d3aefa
Or any other alternative to define type that both accept bool and string from JSON on Go?
from go-midtrans.
imrenagi
commented on August 22, 2024
I dont think so.. is it possible to promote this changes on the new version of this library?
from go-midtrans.
rizdaprasetya
commented on August 22, 2024
Yes make sense, this should be changed to string for next version. But first will need to make proper versioning of this library. Currently we're prioritizing some other development, we'll get back to this once we have proper allocation.
We'll leave this issue open for now, Pull Request from anyone is welcome to address this.
from go-midtrans.
imrenagi
commented on August 22, 2024
Yep. Adding version number will be a good thing to have. I will try to make a PR for changing this to string tho. :D
from go-midtrans.
Related Issues (18)
- wrong type on BCATransferDetail struct HOT 1
- LICENSE unavailable
- Go Report Card Improvement
- Snap SDK did not return "status_code" HOT 1
- Iris gateway? HOT 2
- Expiry support HOT 2
- Mandiri eCash is not found on charge request struct HOT 1
- Installment On Snap HOT 1
- Refund support? HOT 3
- Wrong status_code on Response struct for CoreGateway HOT 2
- Invalid installment struct
- Deny Transaction Method not exist ? HOT 1
- Add payment notification URL feature HOT 1
- No documentation about set custom transaction expired HOT 2
- go-midtrans doesn't work while running inside docker container HOT 2
- Missing channel_status_code and channel_status_message field in CoreGateway Response HOT 2
- custom callback for snap doesnt work HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-midtrans.