Git Product home page Git Product logo

Comments (5)

arunoda avatar arunoda commented on May 2, 2024

@Qix- I think we discussed about this somewhere else.
When we explicitly import node-fetch, it's a lot clear.
There's no need to mention anything about peerDependencies.

On the otherhand, we can simply make node-fetch a dependancy of @zeit/fetch and make an API similar to node-fetch.

from fetch.

Qix- avatar Qix- commented on May 2, 2024

Then I think the constructor should require it IMO. @rauchg thoughts?

from fetch.

TooTallNate avatar TooTallNate commented on May 2, 2024

FWIW it was nice to be able to use a specific version of node-fetch with this module to help identify whether a bug came from this module vs. node-fetch itself (because the beta version of node-fetch exhibited the same bug, so the issues was in @zeit/fetch-cached-dns, for example).

from fetch.

TooTallNate avatar TooTallNate commented on May 2, 2024

We should just drop the require('@zeit/fetch')() implicit syntax IMO.

from fetch.

Ethan-Arrowood avatar Ethan-Arrowood commented on May 2, 2024

Thank you for the report. We are archiving this project; you can read more details here: #83

from fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.