Comments (5)
@Qix- I think we discussed about this somewhere else.
When we explicitly import node-fetch
, it's a lot clear.
There's no need to mention anything about peerDependencies.
On the otherhand, we can simply make node-fetch
a dependancy of @zeit/fetch
and make an API similar to node-fetch
.
from fetch.
Then I think the constructor should require it IMO. @rauchg thoughts?
from fetch.
FWIW it was nice to be able to use a specific version of node-fetch with this module to help identify whether a bug came from this module vs. node-fetch itself (because the beta version of node-fetch exhibited the same bug, so the issues was in @zeit/fetch-cached-dns
, for example).
from fetch.
We should just drop the require('@zeit/fetch')()
implicit syntax IMO.
from fetch.
Thank you for the report. We are archiving this project; you can read more details here: #83
from fetch.
Related Issues (20)
- `Host` header is not properly rewritten upon 3xx redirect HOT 1
- debug package missing?
- Retry *only* upon 5xx status code we know to be retryable HOT 1
- Smaller pool by default HOT 1
- Action required: Greenkeeper could not be activated 🚨
- It creates a new agent on every redirect HOT 2
- Consider not mutating provided opts object HOT 3
- Multipart requests HOT 1
- Allow passing configurable minimumCacheTime through to dns-cached-resolve HOT 4
- Should the types be moved to dev dependencies? HOT 1
- Can't resolve 'dns' HOT 3
- Cannot find requested import 'RequestInit'
- Feature Request: Add support for passing Request object HOT 1
- BUG while pass FormData `body` it will always into HOT 1
- Domains defined in the /etc/hosts file do not resolve HOT 1
- Update dependencies and settle all security vulnerabilities
- vercel/fetch returns 404 for calls that were returning 200 prior HOT 5
- retrying non-idempotent and non-safe requests is considered harmful HOT 4
- Documentation and types are incorrect / incomplete HOT 1
- Archiving `@vercel/fetch`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fetch.