Comments (3)
+1
We want to update a domain of cookie by deleting and recreating it.
This does not work:
response.cookies.set({
name: COOKIE_NAME,
value: '',
domain: `.${host}`,
httpOnly: true,
maxAge: -1,
});
response.cookies.set({
name: COOKIE_NAME,
value,
httpOnly: true,
maxAge: 60 * 60,
});
There is only a single Set-Cookie
header in the response and the last set
takes precedence.
This does work:
response.headers.set(
'Set-Cookie',
`${COOKIE_NAME}=; HttpOnly; Max-Age=0; Path=/; Domain=.${host}, ${COOKIE_NAME}=${
value
}; HttpOnly; Max-Age=${60 * 60}; Path=/;`,
);
Note: we are using Next 13.4.3.
EDIT:
This seems to be unrelated to cookies having the same name. For me it is just always the last instruction no matter which names they have.
There is also a related NextJS issue that has been closed but it is actually not fixed: vercel/next.js#38302
I think using the name
as a key in this Map
causes overwriting cookie instructions for the same name:
edge-runtime/packages/cookies/src/request-cookies.ts
Lines 58 to 59 in bf167c4
from edge-runtime.
@motopods @JannikWempe Can you please reproduce the buggy behavior, pasting a code snippet that can be pasted at DevTools? 🙏
from edge-runtime.
I believe this is fixed by 586de6e; consider commenting if not!
from edge-runtime.
Related Issues (20)
- Expose cookie serialization functions. HOT 1
- Include a key in process.versions for detecting edge runtime HOT 2
- Support `has` in ResponseCookies
- Set-Cookie headers are merged when using `fetch` HOT 6
- Primitives: event-target-shim causes issues w/ edge-runtime running on top of node HOT 3
- drop node16 support
- Proxying primitive instances return anonymous `toString()` return functions
- Why cannot my `fetch` API work in edge function? HOT 4
- 🙏`fetch` api doesn't work in edge function HOT 4
- Which functions and APIs advance the value returned by `Date.now`? HOT 3
- Polyfill for btoa inconsistent with WebApi / Node HOT 5
- drop node18 support
- Response.redirect() fails to parse some URLs in production which parse successfully in local runtime HOT 2
- `@edge-runtime/node-utils` can't start example server from docs using `primitives` (node v18.18.2) Headers2 is not a constructor HOT 1
- Secure Cookies can't be deleted from Responses
- CompressionStream / DecompressionStream support?
- failing on buffer
- Does Edge Runtime use alternative vm instead of node:vm? HOT 3
- crypto.subtle.importKey does not accept ArrayBuffer (ArrayBuffer.prototype mismatch) HOT 1
- Cannot use @edge-runtime/jest-environment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edge-runtime.