Git Product home page Git Product logo

Comments (3)

JannikWempe avatar JannikWempe commented on April 27, 2024

+1

We want to update a domain of cookie by deleting and recreating it.

This does not work:

  response.cookies.set({
    name: COOKIE_NAME,
    value: '',
    domain: `.${host}`,
    httpOnly: true,
    maxAge: -1,
  });
  response.cookies.set({
    name: COOKIE_NAME,
    value,
    httpOnly: true,
    maxAge: 60 * 60,
  });

There is only a single Set-Cookie header in the response and the last set takes precedence.

This does work:

  response.headers.set(
    'Set-Cookie',
    `${COOKIE_NAME}=; HttpOnly; Max-Age=0; Path=/; Domain=.${host}, ${COOKIE_NAME}=${
      value
    }; HttpOnly; Max-Age=${60 * 60}; Path=/;`,
  );

Note: we are using Next 13.4.3.


EDIT:
This seems to be unrelated to cookies having the same name. For me it is just always the last instruction no matter which names they have.

There is also a related NextJS issue that has been closed but it is actually not fixed: vercel/next.js#38302

I think using the name as a key in this Map causes overwriting cookie instructions for the same name:

const map = this._parsed
map.set(name, { name, value })

from edge-runtime.

Kikobeats avatar Kikobeats commented on April 27, 2024

@motopods @JannikWempe Can you please reproduce the buggy behavior, pasting a code snippet that can be pasted at DevTools? 🙏

from edge-runtime.

Kikobeats avatar Kikobeats commented on April 27, 2024

I believe this is fixed by 586de6e; consider commenting if not!

from edge-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.