Git Product home page Git Product logo

Comments (5)

jj-elliott-animus avatar jj-elliott-animus commented on May 28, 2024 4

Yea, I noticed this as well. It seems that Kraken isn't respecting params sent in the GET body.
I've changed my local to:

# Since January 2024, public endpoints only support GET.
        if "/public/" in urlpath:
            self.response = self.session.get(
                url, params=data, headers=headers, timeout=timeout
            )
        else:
            self.response = self.session.post(
                url, data=data, headers=headers, timeout=timeout
            )

        if self.response.status_code not in (200, 201, 202):
            self.response.raise_for_status()`
            
as a temporary fix and it seems to be working.

from python3-krakenex.

veox avatar veox commented on May 28, 2024 1

Post-mortem: this wasn't caught because CI hasn't been working for a while now. :/

The repo has been degrading in "maintenance mode" and I haven't been checking github regularly, for years now. Lucky I did yesterday...

EDIT: Thank you all for sorting this out!

from python3-krakenex.

egner avatar egner commented on May 28, 2024

Same problem here. For now, I go with this workaround in my client code:

data_str = '&'.join([f'{k}={v}' for k, v in data.items()])
method_data = f'{method}?{data_str}' if len(data_str) > 0 else method
response = api.query_public(method_data, timeout=timeout)

from python3-krakenex.

veox avatar veox commented on May 28, 2024

@jj-elliott-animus Very clean workaround!

I'll go review the PR #141 now.

from python3-krakenex.

veox avatar veox commented on May 28, 2024

Closing as fixed; bugfix release 2.2.1 on the way.

from python3-krakenex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.