Comments (4)
This is a nice idea.
First you should create this issue in the actually laravel crm package, this project is an example of using that package. I should actually disable issues on this repo for that reason.
Secondly what you want to do is to create a pull request for your enhancement, we would then review it and merge into the master branch.
Now on the topic of being update to change design style, this might be better handled using the settings table, and adding fields to the settings section of the UI. We actually have plans for this already, open for discussing.
from laravel-crm.
I have worked on a project before where the css was store in the database. The project would used 'state'. State does not always work currently and I found I spent a lot of my time logging, debug and tracking done the issue. For me I would prefer to use env variables with a css.php config file. To querying a database to get css values is not a good idea in my opinion. That is just my opinion
Here are some thinking to think of
-
Performance: Querying a database for CSS values for every page load can introduce additional overhead and slow down the rendering process. Retrieving data from a database typically involves network latency and additional processing compared to reading data directly from a file.
-
Maintainability: CSS is typically considered part of the presentation layer and is best kept separate from the business logic and data storage. By storing CSS values in a database, you mix the concerns of data management and presentation, which can make your codebase more complex and harder to maintain.
-
Flexibility and Scalability: CSS files are designed to be easily editable and modular. By storing CSS values in a database, you lose the ability to easily make changes to the stylesheets and take advantage of the browser's caching mechanisms. Additionally, as your project grows, managing a large number of CSS records in a database can become cumbersome and less scalable.
-
Code Readability: Embedding CSS values within database queries can make the code harder to read and understand. Separating HTML, CSS, and JavaScript into their respective files and keeping them together allows for better organization and clarity.
Another thing that my team brought up is how people will use your project. If a stand alone project, yes css in database not that bad. What if someone is using your project as a composer package? That where things get hairy. We are using your project as a composer package. I know that your using Spadie and a permission.php file is made
'teams' => env('LARAVEL_CRM_TEAMS', false),
and I saw this and thought this could work. Please let me know what you think and if I should continue the steps of sending you the code.
from laravel-crm.
Hello VentureDrake team, just checking in. Does your team want to move forward with me submitting the issue and code ? My lead on the project said if your team wanted to schedule a meeting he would be more than happy to answer any questions. Please let me know. Thank you
from laravel-crm.
Yes, but please submit this on the package repo
from laravel-crm.
Related Issues (20)
- Cant get the basic installation step for seeding? HOT 1
- Unable to install Package HOT 11
- Proper contribution through local package HOT 3
- Feature enhancement HOT 4
- 403 forbidden after login HOT 3
- CRM_Team destroy 403 THIS ACTION IS UNAUTHORIZED. HOT 3
- Font awesome not loading correctly HOT 2
- Spatie Team Enabled Issues HOT 14
- Hardcoded current_crm_team_id
- Organization name is being encrypted on creation. HOT 3
- Errors occurs when ran composer test HOT 2
- Spain translate?? HOT 1
- Problem with the views, controller and routes HOT 1
- SQLSTATE[42S02]: Base table or view not found: 1146 Table 'cncerp.crm_users' doesn't exist (Connection: mysql, SQL: alter table `crm_users` add `url` varchar(255) null) HOT 3
- SQLSTATE[42S02]: Base table or view not found: 1146 Table 'laravel_crm.product_attributes' doesn't exist HOT 1
- Convert lead to deal - Link Product to Deal Error
- Deals does not store into DB the name of a customer HOT 3
- Feature : Customer History ? HOT 2
- Custom fields are not displaying to any model add or edit HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-crm.