Git Product home page Git Product logo

Comments (8)

venth avatar venth commented on June 18, 2024 1

Documentation enhancement released with version 0.6.1

from aws-adfs.

venth avatar venth commented on June 18, 2024

You’re right. Do you think that improving the help by an example would help to clear up the uncertainty?

from aws-adfs.

yermulnik avatar yermulnik commented on June 18, 2024

It definitely would. And a use case would help to understand what this parameter is for. E.g. user can specify which exact role to choose/list by default or which role will be selected/listed by default (I'm not sure I got this parameter's purpose correctly).
By the way we might benefit from this parameter to take the role name only instead of role's arn at large: it's a bit easier to remember the role name comparing to long arn.
Thanks

from aws-adfs.

venth avatar venth commented on June 18, 2024

So, I believe we have here two issues:

  • first about documentation improvement and
  • second about extending login by additional parameter —role-name

from aws-adfs.

yermulnik avatar yermulnik commented on June 18, 2024

Yup, exactly! But I'd say --role-arn could be replaced with --role-name entirely as I suppose most of the people to prefer name comparing to arn as role arn always consists of a static and custom parts: arn:aws:iam::<account_id>:role/ and <role_name> respectively. One another use case from my personal practice: I use aws-adfs to authenticate against a bunch of AWS accounts (in one aws organization) with different types of roles and most of the time I need to use some specific role in several or all of the accounts. So I'd definitely benefit from specifying just a role-name to be assumed in several or all of the accounts returned by adfs auth. For now I have to use my local patches for aws-adfs to list only specific roles in accounts and to assume those in batch.

And thanks a lot for the job you do developing this great tool!

from aws-adfs.

venth avatar venth commented on June 18, 2024

@yermulnik, I've created #73 'Extending login by additional parameter —role-name' to move the discussion about --role-name parameter behavior to separate issue.

from aws-adfs.

venth avatar venth commented on June 18, 2024

Does it look good? Could you close it?

from aws-adfs.

yermulnik avatar yermulnik commented on June 18, 2024

Oh, excuses. Yes, it looks good now. Thank you.

from aws-adfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.