Git Product home page Git Product logo

Comments (13)

michaelbromley avatar michaelbromley commented on September 5, 2024 3

today

from vendure.

michaelbromley avatar michaelbromley commented on September 5, 2024 2

Noting this here for later investigation: perhaps this is related to a recent change in the indexing logic, which in turn is being patched by the following PR

from vendure.

michaelbromley avatar michaelbromley commented on September 5, 2024 1

That indicates some potential issue in configuration perhaps. Is this the DefaultSearchPlugin? Index updates are well covered in our e2e test suite, so I'd be surprised if this is a bug in the plugin itself.

Can you share your config for the search plugin? And if you are able to create a minimal reproduction from a clean installation, that would help a lot.

from vendure.

ankenu avatar ankenu commented on September 5, 2024 1

@michaelbromley I have the same issue. The key "productVariantAsset" is always null. Clearing the search_index_item table and reindexing products does not help. It turned out to reproduce the problem in a newly created project with pre-installed data in SQLite.
My config for the search plugin:

DefaultSearchPlugin.init({ bufferUpdates: false, indexStockStatus: true }),

from vendure.

michaelbromley avatar michaelbromley commented on September 5, 2024 1

This was fixed by the PR mentioned above. Will be available in the next patch release.

from vendure.

casperiv0 avatar casperiv0 commented on September 5, 2024

As a temporary fix, we were able to manually set the productVariantPreview and productVariantAssetId on search_index_item in the database. Obviously, we don't want to do this every time ;)

I tried looking into the cause of this issue, but couldn't fully understand the indexing code in Vendure 😅

from vendure.

michaelbromley avatar michaelbromley commented on September 5, 2024

Is the worker running and updating the search index on changes to the entities?

from vendure.

casperiv0 avatar casperiv0 commented on September 5, 2024

Yeah, looks like it ran successfully:

image

However, it did not update the search index when running the search query

from vendure.

michaelbromley avatar michaelbromley commented on September 5, 2024

OK, and if you update other properties of the product/variant, such as slug, name, etc, are these successfully reflected in the search result after the worker job completes?

from vendure.

casperiv0 avatar casperiv0 commented on September 5, 2024

Nope, doesn't look like it:

In Vendure:
image

Search API result:
image

from vendure.

casperiv0 avatar casperiv0 commented on September 5, 2024

This is the config we're using:

// ...
    DefaultSearchPlugin.init({ bufferUpdates: false, indexStockStatus: true }),
// ...

It's a weird one, since I remember this working at least a version or 2 ago

from vendure.

casperiv0 avatar casperiv0 commented on September 5, 2024

Awesome, thank you!!

from vendure.

kartikjethani-solidity avatar kartikjethani-solidity commented on September 5, 2024

I am facing the same issue. When can we expect this patch release, please?

from vendure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.