Hide version number from admin login page about vendure HOT 10 CLOSED

Maybe you can make a PR for this? the thought of only seeing the version after login is a good proposal. For now if you are worried about your own security backend admin. use the solutions @ashishkpaul is giving.

This is definitely a suggestion, I'm not looking for how to hide the version number from myself.

from vendure.

https://beta-docs.vendure.io/guides/extending-the-admin-ui/admin-ui-theming-branding/#adminuiplugin-branding-settings

from vendure.

https://beta-docs.vendure.io/guides/extending-the-admin-ui/admin-ui-theming-branding/#adminuiplugin-branding-settings

Thanks, but I think you misunderstand what I'm talking about. You can see why I suggested this here: saleor/saleor#13067 (comment)

from vendure.

from vendure.

I can understand, I was on mobile, that's why I just paste the doc link
…
On Fri, 6 Oct 2023, 11:48 Chris, @.> wrote: https://beta-docs.vendure.io/guides/extending-the-admin-ui/admin-ui-theming-branding/#adminuiplugin-branding-settings Thanks, but I think you misunderstand what I'm talking about. You can see why I suggested this here: saleor/saleor#13067 (comment) <saleor/saleor#13067 (comment)> — Reply to this email directly, view it on GitHub <#2428 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4NU75JX4LQF37RT4Z3BRDX56PBRAVCNFSM6AAAAAA5VFFSVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGA2DCOJTGI . You are receiving this because you commented.Message ID: @.>

I don't know what the link you pasted has to do with what I'm talking about.

from vendure.

https://beta-docs.vendure.io/guides/extending-the-admin-ui/admin-ui-theming-branding/#adminuiplugin-branding-settings

You make me feel like you just read the title and not the content. I'm not asking how to hide the version number for myself. I am suggesting that from a security perspective, we remove the version number from the login page, which is better for everyone.

from vendure.

"Can we consider deleting the version number on the admin login page?"

import { VendureConfig } from '@vendure/core';
import { AdminUiPlugin } from '@vendure/admin-ui-plugin';

export const config: VendureConfig = {
    // ...
    plugins: [
        AdminUiPlugin.init({
            // ...
            adminUiConfig:{
                brand: 'My Store',
                hideVendureBranding: false,
                hideVersion: true, // ----------------> this will hide the version no
            }
        }),
    ],
};

the above snippet can simply hide the version no from the admin login page

from vendure.

https://beta-docs.vendure.io/guides/extending-the-admin-ui/admin-ui-theming-branding/#adminuiplugin-branding-settings

You make me feel like you just read the title and not the content. I'm not asking how to hide the version number for myself. I am suggesting that from a security perspective, we remove the version number from the login page, which is better for everyone.
Okay, the better way to post a query in a Discord channel might be for someone to give you a better overview.

from vendure.

"Can we consider deleting the version number on the admin login page?"

import { VendureConfig } from '@vendure/core';
import { AdminUiPlugin } from '@vendure/admin-ui-plugin';

export const config: VendureConfig = {
    // ...
    plugins: [
        AdminUiPlugin.init({
            // ...
            adminUiConfig:{
                brand: 'My Store',
                hideVendureBranding: false,
                hideVersion: true, // ----------------> this will hide the version no
            }
        }),
    ],
};

the above snippet can simply hide the version no from the admin login page

Well, you don’t understand what I’m talking about, you can ignore it.

from vendure.

Maybe you can make a PR for this? the thought of only seeing the version after login is a good proposal.
For now if you are worried about your own security backend admin. use the solutions @ashishkpaul is giving.

from vendure.