Comments (8)
Hi Matt, that beta looks to be working. Not getting the error anymore
from vendr-payment-provider-paypal.
Hmm, interesting, I've recently been porting this over for thew new Umbraco version of Vendr and that seems to have been working fine. I have upgraded all dependencies though so I wonder if upgrading Flurl would fix that? 🤔
from vendr-payment-provider-paypal.
Hi Matt,
Just wanted to drop you a quick update on this.
I created a custom payment provider within my project that targetted the .net7 framework. It uses 99% of the code from the original PayPal provider, the only changes really are to account for the updated APIs in the dependencies.
I was able to drop a couple of dependencies for Microsoft.AspNet.WebApi.Client
and NETStandard.Library
, and bumped the other two upto Flurl.Http 3.2.4
and Vendr.Core 3.0.11
.
There was one 'gotcha' to be careful of, it doesn't throw a build error but it causes issues at run time:
On the second line of the PayPalClient.ParseWebhookEventAsync
method, the headers were originally coming from request.Content.Headers
, but during runtime they didn't contain the correct headers. Turns out the correct headers are now on request.Headers
. I'm assuming this is just a quirk caused by the updated APIs.
Anyway, the callbacks now seem to be working correctly, and orders are being finalized as expected.
I've still got some more testing to do but just thought I'd keep you in the loop.
from vendr-payment-provider-paypal.
Hi,
Experiencing this issue too. Is the fix going to be brought back from Umbraco Commerce?
Thanks
from vendr-payment-provider-paypal.
I'm not sure if the original issue was raised against 2.0.1 beta but looking at the 2.0.1 tagged codebase it is set to use request.Headers
https://github.com/vendrhub/vendr-payment-provider-paypal/blob/v2.0.1/src/Vendr.PaymentProviders.PayPal/Api/PayPalClient.cs#L90
What version are you using using @TQ-Benji ?
from vendr-payment-provider-paypal.
We are using 2.0.1
from vendr-payment-provider-paypal.
Ok, so I've pushed a v2.0.2-beta0003 build to our unstable feed at https://nuget.outfield.digital/unstable/vendr/v3/index.json I believe this should work around the issue. Unfortunately I don't currently have a PayPal test environment setup so if anyone is able to test it and provide feedback that would be super useful.
from vendr-payment-provider-paypal.
I've basically swapped this bit to construct my own content object passing in the media type which is what appears to be missing in specific .NET versions https://github.com/vendrhub/vendr-payment-provider-paypal/blob/v2/hotfix/2.0.2/src/Vendr.PaymentProviders.PayPal/Api/PayPalClient.cs#L118
from vendr-payment-provider-paypal.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vendr-payment-provider-paypal.