Clojure 1.8 stacktraces problem about ultra HOT 14 CLOSED

I think this is because stacktraces within the tests are using a stacktrace printing method that I haven't targeted. Trying to run the tests at the REPL produces the same result. I'll look into this further.

from ultra.

Thanks! Love your plugin, by the way. Every Clojurist at my company is using it 👍

from ultra.

What version of Ultra are you using? It should be working with lein test.

from ultra.

0.4.1

clone https://github.com/Trylobot/hive-clj
lein test

from ultra.

Hmm. So, Ultra is active, but it's not active for stacktraces. I'll look into this.

from ultra.

That's awesome! What company?

from ultra.

Yodle (just acquired by web.com)

from ultra.

Hello! I had a look at this and I think adding the following to the ultra.test namespace would solve the issue:

(defmethod report :error [m]
  (with-test-out
   (inc-report-counter :error)
   (println "\nERROR in" (testing-vars-str m))
   (when (seq *testing-contexts*) (println (testing-contexts-str)))
   (when-let [message (:message m)] (println message))
   (println "expected:" (pr-str (:expected m)))
   (print "  actual: ")
   (let [actual (:actual m)]
     (if (instance? Throwable actual)
       (pretty-repl/pretty-print-stack-trace actual)
       (prn actual)))))

This is adapted from the original report code here:
https://github.com/clojure/clojure/blob/clojure-1.8.0/src/clj/clojure/test.clj#L383-L394

With the only difference being (pretty-repl/pretty-print-stack-trace actual) instead of (stack/print-cause-trace actual *stack-trace-depth*)

from ultra.

@Jell wanna make a PR? 😄

from ultra.

@venantius I made one here: #73

from ultra.

Any update on this?

from ultra.

Just left some comments on the PR.

from ultra.

I've updated the PR

from ultra.

This has been resolved by #73 -- I'll push out a release later today.

from ultra.