Comments (14)
I think this is because stacktraces within the tests are using a stacktrace printing method that I haven't targeted. Trying to run the tests at the REPL produces the same result. I'll look into this further.
from ultra.
Thanks! Love your plugin, by the way. Every Clojurist at my company is using it 👍
from ultra.
What version of Ultra are you using? It should be working with lein test.
from ultra.
0.4.1
clone https://github.com/Trylobot/hive-clj
lein test
from ultra.
Hmm. So, Ultra is active, but it's not active for stacktraces. I'll look into this.
from ultra.
That's awesome! What company?
from ultra.
Yodle (just acquired by web.com)
from ultra.
Hello! I had a look at this and I think adding the following to the ultra.test
namespace would solve the issue:
(defmethod report :error [m]
(with-test-out
(inc-report-counter :error)
(println "\nERROR in" (testing-vars-str m))
(when (seq *testing-contexts*) (println (testing-contexts-str)))
(when-let [message (:message m)] (println message))
(println "expected:" (pr-str (:expected m)))
(print " actual: ")
(let [actual (:actual m)]
(if (instance? Throwable actual)
(pretty-repl/pretty-print-stack-trace actual)
(prn actual)))))
This is adapted from the original report code here:
https://github.com/clojure/clojure/blob/clojure-1.8.0/src/clj/clojure/test.clj#L383-L394
With the only difference being (pretty-repl/pretty-print-stack-trace actual)
instead of (stack/print-cause-trace actual *stack-trace-depth*)
from ultra.
@Jell wanna make a PR? 😄
from ultra.
@venantius I made one here: #73
from ultra.
Any update on this?
from ultra.
Just left some comments on the PR.
from ultra.
I've updated the PR
from ultra.
This has been resolved by #73 -- I'll push out a release later today.
from ultra.
Related Issues (20)
- compatibility with leiningen 2.9.0 HOT 4
- Ultra assert-expr changes `:actual` value
- Please support Java 11 HOT 1
- Does not work for JDK 12 + Clojure 1.10.0
- Does not work for JDK 12 + Clojure 1.10.0 + lein 2.9.1 HOT 9
- Exception with Puget when running lein repl HOT 4
- Fix `source` to follow provided custom colorscheme
- Ultra causes CIDER to hang indefinitely when running tests with some values HOT 11
- Comparisons between PersistentArrayMap and PersistentHashMap should diff on keys, not types HOT 1
- Whitespace in string diffs is incorrectly eliminated in tests.
- Test reporting can cause test code to run twice HOT 14
- On the main page you suggest to use version 0.5.3 but it does not exist HOT 1
- Is clojure 1.9 supported yet? HOT 5
- Newer ClojureScript versions clashes with rrb-vector which prevents building HOT 4
- If ultra is "finished" can the version reflect it? HOT 1
- Colors not working on Windows HOT 2
- using circleci.test with ultra HOT 5
- Update org.clojure/tools.nrepl 0.2.12 to nrepl 0.5.3? HOT 6
- Declare middleware HOT 5
- Broken on JDK11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ultra.