Support "exclude" in packages config about mockery HOT 4 CLOSED

@LandonTClipp @kpaulisse is this part of mockery 2.36.0?

My "exclude" direction in the config file is ignored, not sure if I'm doing it wrong?

i.e this is my config file:

with-expecter: true
dir: "{{.InterfaceDir}}/mock" 
outpkg: "mock"
filename: "{{ .InterfaceName | snakecase }}.go"
mockname: "{{ .InterfaceName | firstUpper }}"
packages:
  org/bla/bla/package1:
    config:
      recursive: True
      exclude:
        - reinforced
      include-regex: ".*"
      exclude-regex: ".*[Oo]ption"
  org/bla/bla/package2:
    interfaces:
      OptionMessageHandler:
  org/bla/bla/package3:
    config:
      dir: "./internal/db/testutils/mock"
    interfaces:
      Tx:
      Transactor:

It still generates mocks for the reinforced packages (I also tried using the complete import name, i.e "org/bla/bla/package1/whatever/reinforced", that didn't work either).

from mockery.

@tzachshabtay I believe you need to specify a path that's relative to org/bla/bla/package1. So if the absolute path of the thing you're trying to exclude is org/bla/bla/package1/whatever/reinforced then you'll want

exclude: 
- whatever/reinforced

If this is indeed the case, I need to update the docs to make this more clear.

from mockery.

You are right, I am kicking myself that I did not name this better. The reason this happened was because exclude was a parameter in the legacy config and someone sent in a pr to port this to the new config. I did not think clearly enough to prevent this unclear naming, that is my fault.

That doesn't mean we couldn't also add an exclude-package-regex parameter. To make this better for v3 I'm also totally fine with adding exclude-package that does the same thing as exclude, and then deprecate the usage of exclude.

If anyone wants to submit an issue to discuss a proposal for any of these ideas, I am likely to accept it.

from mockery.

@LandonTClipp ah thanks, relative path works.

As an aside, what I really would have liked here is an exclude regex, this would have allowed me to exclude .*reinforced, and not to have to write a line for each reinforced package.

I would have renamed the current exclude-regex to exclude-interface-regex (and include-interface-regex) and have this one as exclude-package-regex.

from mockery.