Comments (25)
You could probably use a contains function in this condition
https://github.com/vega/ts-json-schema-generator/blob/master/azure-pipelines.yml#L58
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=vsts#contains
I am trying to think about what options there might be to improve that. In your case it seems you would want to update the triggers section to include triggering on refs/tags and refs/heads
Today you can do this
trigger:
branches:
include:
- refs/heads/master
- refs/tags/*
This might be better
trigger:
branches:
include:
- refs/heads/master
tags:
include:
- refs/tags/v*
and then have a variable automatically set called TagName or something like that.
from ts-json-schema-generator.
It shouldn't be but I will look into it
from ts-json-schema-generator.
@domoritz sorry for the delay. The fix will rollout on Monday of next week.
from ts-json-schema-generator.
@domoritz I apologize for this not working. Someone from our engineering team will comment here today and work with you to figure out what might be going on.
from ts-json-schema-generator.
I not sure we have something in the environment that looks at the commit being built and determines if there is a tag on it. You can trigger on tags so it is possible you could use the fact that the branch is refs/tags instead of refs/heads in your condition.
from ts-json-schema-generator.
Thank you, I'll try that. It would be sweet if there was tighter integration with git tags to make releases easier.
from ts-json-schema-generator.
Hmm, https://github.com/vega/ts-json-schema-generator/blob/master/azure-pipelines.yml#L24 doesn't seem to trigger builds for tagged commits. Or at least I don't see anything at https://dev.azure.com/vega-vis/ts-json-schema-generator/_build?definitionId=3.
from ts-json-schema-generator.
If you edit that build pipeline in the UI check the triggers tab and make sure that UI configuration is not overriding the YAML config
from ts-json-schema-generator.
from ts-json-schema-generator.
Hmm, and now I ran into https://aka.ms/yamlauthz again although it worked before.
from ts-json-schema-generator.
Builds not triggered on tagged commits seems to be a common problem with azure pipelines. See https://visualstudio.uservoice.com/forums/330519-visual-studio-team-services/suggestions/13326927-trigger-build-when-pushing-tag-to-git. @chrisrpatterson is this a known issue?
from ts-json-schema-generator.
Someone just asked the same question on stack overflow: https://stackoverflow.com/questions/52615283/how-do-you-trigger-a-build-in-azure-pipelines-when-a-new-tag-is-pushed-to-github
from ts-json-schema-generator.
I have found at least part of the issue. Pushing new tags to the head commit works fine if you are using the Oauth flow to auth to Github repos but not if you are using the GitHub App flow. This stems from the fact that the events are delivered differently to us from Github in each of those scenarios. We are currently working to address it.
from ts-json-schema-generator.
Thank you for looking into this @chrisrpatterson! I'll have to remember to make manual releases until this is fixed. Is there a public issue I can follow or can you ping me when this is fixed?
from ts-json-schema-generator.
@chrisrpatterson is there a timeline for fixing this in azure pipelines? Otherwise, I might have to revert to using Travis.
from ts-json-schema-generator.
🎉 thank you!
from ts-json-schema-generator.
@chrisrpatterson it still does not work. I don't see any builds for tags. Can you help me? Otherwise, I will return to Travis.
from ts-json-schema-generator.
Hi @domoritz, I'm looking into this. Could you please clarify something? How are you authenticated w/ GitHub? Are you using the Azure Pipelines GitHub App? Or are you using OAuth or PAT? Thanks!
from ts-json-schema-generator.
Hi @domoritz, if you are authenticated with the GitHub App, we made a change a few minutes ago. Tags were only working w/ OAuth and PAT, but now they're enabled with the Azure Pipelines GitHub App. If this is still not working for you, could you please tell me what your Azure DevOps account name is? (lukillgo at microsoft dot com if you'd prefer email) Thanks!
from ts-json-schema-generator.
Thank you @chrisrpatterson and @lkillgore. I am using the GitHub integration. Let me make a tagged commit and see what happens.
from ts-json-schema-generator.
Works perfectly. Thank you all!
https://dev.azure.com/vega-vis/ts-json-schema-generator/_build/results?buildId=92&view=logs
from ts-json-schema-generator.
Thanks for letting us know! Apologizes for the inconvenience.
from ts-json-schema-generator.
@lkillgore @chrispat Has there been a change recently? My tagged commits are no longer being built.
from ts-json-schema-generator.
We're been seeing this issue too since two days ago.
Updated: Sorry I guess this is an Azure Pipelines issue, not necessarily related to this project directly.
from ts-json-schema-generator.
I decided to switch to CircleCI, which also took some.wffort to get working but it works like a charm now.
from ts-json-schema-generator.
Related Issues (20)
- RegExp types are now emitted, breaking schema validation (v2.1.1) HOT 1
- Error when following exports?
- Dist types now require @types/ts-expose-internals HOT 9
- Fix CJS imports HOT 8
- Invalid index in type HOT 11
- CLI - ENOENT: no such file or directory, open 'package.json' HOT 3
- Error: Unknown type "undefined" HOT 2
- Required types not allowed HOT 1
- Generator crashed when no package version is set HOT 4
- Any way to indicate that a string is actually a date-time? HOT 7
- Breaking changes from v1 to v2 HOT 1
- Support for `"format": "uri-reference"` HOT 3
- Incorrect typing when a type uses Omit and inherits properties from a grandparent interface
- `--expose all` breaks generation with generic types. HOT 4
- How do you use ajv with references? HOT 4
- create schema uses `anyOf` instead of `allOf` HOT 5
- When I use discriminator, I am getting an error where it can't find the specific field HOT 1
- Allow using dependencies schema on certain prop HOT 4
- Undefined reference in ObjectLiteralExpressionNodeParser when using typeof on a spread const HOT 2
- Schema generator fails when nested property name is StringLiteral (kind 11) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ts-json-schema-generator.