Git Product home page Git Product logo

Comments (3)

Godnoken avatar Godnoken commented on September 15, 2024

unsafe extern "system" fn imgui_dxgi_swap_chain_present_impl(

I know next to nothing about swap chains, but it seems that the ImguiRenderer gets invoked more than once inside of it in some cases. Or perhaps something is loaded/unloaded several times in the launch process of these games, causing it to reinitialize?


Edit

Aha.. just noticed that the Mutex holding ImguiRenderer gets reinitialized inside the imgui_resize_buffers_impl, my bad.
What's the reason for this? Tried removing it and things seem to work just fine on my end.
I noticed that the OpenGL3 hook doesn't seem to reinitialize the ImguiRenderer anywhere either.

You can also likely ignore my earlier comment about game input getting weird because of it - doesn't seem to be the issue.

from hudhook.

veeenu avatar veeenu commented on September 15, 2024

Hi! Sorry for the delay, been quite busy.

In some games (definitely DS3 and ER) not reinitializing the renderer means that the UI won't scale alongside resizing the window, at best, or crash, at worst.

The fact that it gets called multiple times with early injections makes me think that resize is just called pointlessly by the game/engine a number of times while nothing is still getting rendered yet -- I wouldn't say this is something hudhook should work around.

from hudhook.

Godnoken avatar Godnoken commented on September 15, 2024

Hi! Sorry for the delay, been quite busy.

No worries, no pressure, just happy to get a response eventually!

In some games (definitely DS3 and ER) not reinitializing the renderer means that the UI won't scale alongside resizing the window, at best, or crash, at worst.

Aha! I suppose I should just make changes on my own end then. I have some functionality in the initialize function that I'd rather not have run more than once.

The fact that it gets called multiple times with early injections makes me think that resize is just called pointlessly by the game/engine a number of times while nothing is still getting rendered yet -- I wouldn't say this is something hudhook should work around.

Absolutely correct, thank you for the input mate. I'll close this one.

from hudhook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.