Comments (3)
Line 77 in 4c2968d
I know next to nothing about swap chains, but it seems that the ImguiRenderer gets invoked more than once inside of it in some cases. Or perhaps something is loaded/unloaded several times in the launch process of these games, causing it to reinitialize?
Edit
Aha.. just noticed that the Mutex holding ImguiRenderer gets reinitialized inside the imgui_resize_buffers_impl
, my bad.
What's the reason for this? Tried removing it and things seem to work just fine on my end.
I noticed that the OpenGL3 hook doesn't seem to reinitialize the ImguiRenderer anywhere either.
You can also likely ignore my earlier comment about game input getting weird because of it - doesn't seem to be the issue.
from hudhook.
Hi! Sorry for the delay, been quite busy.
In some games (definitely DS3 and ER) not reinitializing the renderer means that the UI won't scale alongside resizing the window, at best, or crash, at worst.
The fact that it gets called multiple times with early injections makes me think that resize is just called pointlessly by the game/engine a number of times while nothing is still getting rendered yet -- I wouldn't say this is something hudhook
should work around.
from hudhook.
Hi! Sorry for the delay, been quite busy.
No worries, no pressure, just happy to get a response eventually!
In some games (definitely DS3 and ER) not reinitializing the renderer means that the UI won't scale alongside resizing the window, at best, or crash, at worst.
Aha! I suppose I should just make changes on my own end then. I have some functionality in the initialize function that I'd rather not have run more than once.
The fact that it gets called multiple times with early injections makes me think that resize is just called pointlessly by the game/engine a number of times while nothing is still getting rendered yet -- I wouldn't say this is something
hudhook
should work around.
Absolutely correct, thank you for the input mate. I'll close this one.
from hudhook.
Related Issues (20)
- Gate renderers/hooks behind feature flags
- [DX9] Some games do not reset at window resizing
- Remove nightly feature flags
- Allow DirectX hooking using existing device pointer HOT 7
- Build `wgpu` renderer
- Windows-GNU build target unsupported HOT 2
- Function hooking HOT 2
- Expose ImGui Context HOT 3
- `ImguiRenderLoopFlags` is never updated HOT 2
- Bug with Clipboard HOT 1
- Clean up lifecycle API and entry point
- Build failed on --target i686-pc-windows-msvc HOT 6
- Encountered an issue while using the Example Dx11 Hook with Dx11Game Rune Factory 5 HOT 15
- Support `no_std` HOT 1
- DX9 Hook non-functioning HOT 2
- Inject not a function HOT 4
- DX9 ImGui unresponsive HOT 3
- using image in dx9 hook HOT 1
- Crashes while unhooking HOT 1
- The WGPU experiment HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hudhook.