Repair team about library HOT 175 CLOSED

As of today (March 3rd), all open-source community plugins are in one the following categories:

• Upgrade to v0.6 completed and tested on supported platforms (Lin, Mac, Win)
• Upgrade in progress by plugin developer
• PR for upgrade to v0.6 was provided to developer, not merged yet

The Plugin Repair team will continue to monitor status of upgraded plugins and test on all supported platforms. The status post a the top will be updated as new information is available.

The work is not done, but we have made great progress in the last 17 (!) days towards our goal of having all community plugins available in time for the Rack v0.6 release.

Thank you to all PR contributors (@phdsg, @alikins, @dizzisound).
Thank you to @phdsg for testing of upgraded plugins on Linux and Mac platforms.

This effort is exemplary for the great Rack community that @AndrewBelt has created.

from library.

This submodule repos thing is really cool. Everything built straight out of the box for me, and I tested it with a build against Rack-SDK which will be the new method for developing plugins without compiling Rack.

The Build Team will therefore by me for at least two weeks after the Rack 0.6 release, and I'll host files on the vcvrack.com website or something. I'll make builds at least as often as once a day and figure out the obstacles for doing it as a community effort.

The next step is the Library Team. I'll put together a workflow to begin making new JSON manifests for each plugin.

from library.

I develop DHE-Modules, and have completed the conversion myself.

from library.

PulsumQuadratum-rtlsdr: I'm doing it myself. (It also needs to have its dependencies built as git submodules before it will build without special instructions)

from library.

@cschol

I'll do mine myself, and can help with others if you need it.

from library.

@cschol fixed mine just now

from library.

Bogaudio is up to date. Cheers.

from library.

I will take care of MrLumps. Thanks!

from library.

I have converted my plugin ('Alikins') to the 0.6 API in it's master branch.

from library.

Done upgrading my plugins at least on MAC (phewwwww)
Tomorrow morning I will (hopefully) compile everything for Windows and Linux.
getting ready for 0.6 :-)

from library.

I've built my plugin ('Alikins') for v0.6 on lin/mac/win and tested on linux and mac.

from library.

Checked just means somebody did work or signed up for doing work. If the module is bold and the clone URL is available, the source code is publicly available and the module is ready to be tested on all platforms. I'll clarify in the post above later today.

from library.

Hello, I am developing bidoo plugins and I started the upgrade to 0.6. I target to push my code to github this week-end. I think it should be ok on Win and Lin but I expect some issues on OS X since my last release doesn't work on all OS X versions. Best.

from library.

0.6 is already available in the osc branch; will merge in the master branch soon

from library.

Not that it matters now, but I've ported Grayscale, PulseMatrix, and Console, and builds will be available upon the 0.6 release.

from library.

v 0.6.0 now on master branch

from library.

Aepelzens Parasites also built and run on latest Rack master, on Fedora 23 Linux.

from library.

VCVia needs a lot of work; I might as well do the transition to 0.6 myself while I am at it. Finally getting around to it. Thanks!

from library.

Looks great, I'm working on mine.
People can't check your own checkmarks, they'll just have to post here.

from library.

Pr for mtsch at mtsch/mtsch-vcvrack-plugins#5

from library.

I will update moDllz... just waiting to see how the MIDI is implemented

from library.

cf - working on mine, may need some help at some point, will ask here and/or there
EDIT : done, everything working fine and uploaded to my repo :)

from library.

i'll work on mine (Southpole) - the update will depend somewhat on the various MI / Parasites repos i copied from

from library.

I've done AmalgamatedHarmonics.

from library.

I'll work on mine

from library.

ok mental modules are done, the new code is on the 06dev branch.

from library.

Ohmer Module can compile against 0.6.0dev without error/warning, but Git fork and Co. hum... is like Chinese language for me!

I don't want to touch current release (0.5.3) on my repo, I've created a Pre-release 060devhere and posted related source code, but as usual here I'm lost in the Matrix! ;)

from library.

If someone wants to take a crack at 'dekstop' plugin, dekstop/vcvrackplugins_dekstop#17 has a incomplete pass at it.
Not sure how to handle the templates in dekstop/src/Recorder.cpp correctly...

from library.

PR sent for RODENTMODULES #rodentcat/RODENTMODULES#3

from library.

@DomiKamu If you have updated your plugins yourself you don't need to worry about the "fork" part. Once Rack v0.6 is released, you can merge your 060dev branch into master and release the new version. "Forks" are only required if someone else was going to update your plugin and wants to send you a Pull Request with the changes.

from library.

I finished the update to AS modules(tested on Mac), but branches and tags are still too confusing for me. If someone wants to guide me thru it I'll do it, otherwise I'll wait, thanks.

from library.

@cschol
update: 2018-02-27
some false positives slipped in yesterday, because i still had headers in rack's /ext dir that were moved to /dep in one of the last commits. so bidoo's ouaive(fixed 2018-02-28) and cf's PLAYER(fixed 2018-03-01) should've failed with a wrong include path, but didn't.

working, unlisted

• Bacon Music - all platforms: good
• JLmod - all platforms: good

from library.

Fundamental, Befaco, ESeries, and AudibleInstruments are updated to the Rack 0.6 API

from library.

This issue is for community/management discussions only. Off-topic comments will be removed without notice. Open an issue in the respective repo for issues about that repo.

from library.

Ohmer Modules v0.6.0.2-beta - against lastest Rack 0.6, is available on 060dev branch, for validation.

from library.

bidoo's pack is ready for v 0.6.0 on master

from library.

Great work everyone.

I think that we've worked together so well on this is both a vindication of Andrew's trust in the user community and confirmation of what a cool bunch of people are involved in the project.

Thanks everyone involved.

from library.

makefiles updated as requested

from library.

Aepelzens Modules build and run on Fedora 23 Linux with latest Rack master git pull.

from library.

moDllz updated to 0.6 on
https://github.com/dllmusic/VCV_moDllz/tree/master-0.6.0dev
Mac built ... need help with win and Linux. Thanks

from library.

@dllmusic Windows and Linux built fine. Thank you!

from library.

@liquidcitymotors Before releasing your module, I strongly prefer that you not include the name "VCV" in the name of your plugin, as it can confuse users into thinking that it is an official plugin made by VCV, and it can dilute the brand.

from library.

Didn't consider that, my apologies! I will sort that out ASAP.

from library.

I'll do Dekstop, if no one else is working on it. I found a way to painlessly replace libsamplerate for
vrackplugins_dekstop Recorder.cpp.

from library.

@dizzisound No worries! You contribution is as official as mine. Thank you! I do have to say I would prefer to only add modules right now that are known to be working on all platforms and add new working ones one by one. This would make some kind of automated CI easier for the 0.6 versions. @AndrewBelt, what to you think?

from library.

Ah, we're on the same page then. As long as it's not "some server in an unknown location" doing things on each PR. Orchestrating events is a huge mess with TravisCI, CircleCI, Jenkins, etc that is a non-problem when you initiate it each time with git pull, make whatever

from library.

#281
Make an exception for that one and use ValleyFree as the directory name

from library.

@cschol

Alikins (3/13/18 compile fail, reported to developer)

alikins/Alikins-rack-plugins#1 fixed in alikins/Alikins-rack-plugins@9a19cc4

from library.

Additional plugins update: PR pending for @teletypist Stochasm here: Updated to Rack 0.6 API

from library.

This post contains the list of all open source plugins in the community repository that need to be validated against the v0.6 API.

If you are interested in helping per @AndrewBelt's instructions above, please

1. Post below with module name that you are working on, so other developers know that it is being taken care of. I will take care of keeping the list up to date with checking off plugins from the list.

2. reference this issue (link to: https://github.com/VCVRack/community/issues/269) in your Pull Request to the plugin repository so we can track the Pull Requests and their completion.

If you are a PLUGIN DEVELOPER and you know you would like to handle the conversion to the v0.6 API yourself without the help of the Repair Team, please comment below.

A checkmark means the plugin is actively being worked by the Repair Team OR the developer has decided to do the update themselves.

Once the plugin is confirmed to be migrated to v0.6, i.e. source code is available in the developer's repository, the plugin name will be marked bold and a clone url will be added.
Once the plugin is building on all supported platforms (Linux, Windows, Mac), the plugin will be crossed off the list.

PLEASE NOTE: Once a plugin has been MIGRATED TO THE NEW REPOSITORY structure, the plugin will be REMOVED from this list! It will be re-added if further issues are found that need attention.

Last update of plugins: 9/1/2018

Remaining plugins:

• CastleRocktronics (3/25/18 PR pending)
• dekstop (3/21/18 Should follow the Fundamental example to include libsamplerate as a dependency for the plugin)
• JE (3/25/18 PR pending)
• PulsumQuadratum-rtlsdr
• StellareModular-Link (3/18/18 Depends on 3rd part library, reported to developer)
• IO-Simple (7/30/2018 has graphics issues and requires slug update)

Additional plugins (not in community repository yet):

• JLmod | clone url (3/25/18 Needs VERSION update, reported to developer)
• Via For VCVRack | clone url (4/8/18 Pending intergration into community repository)
• TechTechTechnologies | clone url
• JEM-Modules | clone url

from library.

@phdsg Oops. That was an artifact of how I generated the list. Removed. Thanks.

from library.

@AndrewBelt Crap, I was hoping they could. I'll keep the list up to date from people posting here below. Updated the instructions above to have people post the name of the module they are working on.

from library.

@Strum Thank you. Which ones are your's again?

from library.

Added one additional instruction to make sure that your Makefiles are up-to-date and follow the Template Makefile or the Fundamental Makefile.

from library.

@phdsg thanks.

from library.

Thank you for the PR @alikins!

from library.

I am updating my plugins, started a couple of days ago, I will (hopefully) finish them tonight. Bear with me I am quite busy and there are quite a lot of changes to be done ;-) also, my https://github.com/antoniograzioli/Autodafe repository is a complete mess, and needs to be erased completely...

from library.

Is AudibleInstruments building for people? I.e. should it be unchecked?

from library.

@wizardishungry "Checked" means "somebody is working on it" (in this case @AndrewBelt). Once plugins are confirmed to be building against v0.6, I'll cross them off the list.

from library.

@cschol Could you add the checked/strikeout note in your main post?

from library.

@antoniograzioli

well done.

from library.

@alikins Thanks for the PR! Sent you a supplemental PR to that port_to_v0.6 branch to finalize the dekstop plugin conversion.

from library.

Hi, as I've indicated yesterday, unfortunately the "fork" story isn't clear in my mind.
However, source code against v0.6.0 is placed in new branch (060dev):
https://github.com/DomiKamu/Ohmer-Modules/tree/060dev

If somebody can explain clearly what I must doing, be sure it will be appreciated, thanks in advance.

from library.

@phdsg I've deleted the posted reply, so please apologize me, you've understood I'm totally lost in this "can of worms" (I see GitHub like this, really isn't user-friendly in particular for unexperimented users). Also the initial message was not for me, I've understood but late, BTW sorry again x 1000! ;) :-)

EDIT: on second thought, I've replied (quickly) because your message above was a reply... on mine, as you've said :-) :-) sure it's not your fault.

from library.

I have decided to change the plugin list format a little bit, see the updated notes in the post above.

The plugin API conversion is progressing nicely with developers making changes as well as PRs being created. As PRs are merged and developers are done making their own changes, the next step is to start building the available source code on all supported platforms to flush out any potential cross-platform issues.

I will mark plugins ready for testing (with clone url) and the platform where the build/test has been successfully completed.

Any help in building available plugins against v0.6 once the plugin source code is available is much appreciated. Check the list, pick a platform that has not been tested yet, build the plugin source code from the developer's repository, and report any issues to the PLUGIN DEVELOPER. Success can be reported in this thread.

from library.

@AScustomWorks Are your changes committed?

from library.

@cschol not yet

from library.

@phdsg Thank you for testing and the PR.

from library.

@phdsg You can edit the post if you are planning on keeping on testing on Linux. I'll check your post.

from library.

v 0.6.0 ready on master branch: AS

from library.

@davephillips Thank you! Just be aware of this issue. Rack v0.6 will not ship with libsamplerate anymore and you either need to update the code or ship libsamplerate yourself.

from library.

@liquidcitymotors Great! If you are done, if you could submit a PR to the community repo to get your plugin added that would be awesome.

from library.

Thanks @liquidcitymotors!

from library.

Sign me up for the Repair Team. I can adopt and upgrade to 0.6. Build and testing on Linux and Windows.
https://github.com/hwpfeil/vcvrack

from library.

Thank you @hwpfeil. Please provide a PR to the dekstop plugin developer.

from library.

Clean compile on https://github.com/hwpfeil/vcvrack/vcvrackplugins_dekstop in Windows 10 mingw64.
Everything works as advertised. I need to fix the Recorder graphics (record button and input jacks out of place) and build/test on Linux.

The only other community src using libsamplerate is AepelzensModules. I built and tested that using SoX Resampler Library in both mingw64 and Linux. Open issues: Makefile needs to restrict the soxr lib and header to Folder.cpp; mingw64 can't find the runtime dll in Rack/plugin. It works if I put it in Rack/dep/bin or mingw64/bin. I prefer the former, I'd rather locate everything cleanly within Rack/plugins, or Rack/dep if necessary. The install package would have to put a soxr dll in Rack/dep/bin somehow. Folder.cpp uses src_new(), which pulls in multiple files. Might be able to identify the needed functions and header definitions, put them in a companion cpp and compile it into Folder.cpp.o for a clean link?

from library.

@hwpfeil Are you planning on providing Pull Requests to the developers?

One question: why are you replacing libsamplerate with SoX? Rack used to use libsamplerate itself and was shipping with it, that's why plugin developers were using it. v0.6 does not ship with libsamplerate anymore since it uses libspeexdsp. Therefore, the plugin dependency of libsamplerate must be provided by the plugin. If you need to ship a library anyway with the plugin, you might as well ship libsamplerate. Thoughts?

from library.

https://github.com/hwpfeil/vcvrack/vcvrackplugins_dekstop built and tested on Linux. Ready for build/test on Mac. Release to Build Team?

from library.

@cschol I'm a git noob. Don't know how to provide Pull Requests. I thought if I release the code, folks could copy it?
Only two 0.51 plugins use libsamplerate. Dekstop Recorder.cpp used only one simple function, so I was able to embed the necessary code. The other libsamplerate instance is AepelzensModules Folder.cpp. I used that as a learning experience in plugin design and upgrade, before I created a github account and found out you had already adopted it. I found the thread asking for a libsamplerate replacement. Sox Resampler was easy, its header wraps all of the SRC functions, like src_new(), src_delete(). I wasn't involved in the replacement discussions a couple of months ago, I know Audacity migrated to SoX, so I looked at it, found an easy fix, and, suffering from bouts of congenital indolence as I oftentimes do, decided to try it. After the 0.6 rollout we'll have more time to incorporate a skeleton version of soxr into Folder.cpp. Now you know the rest of the story. I'd be happy to go back to work on Folder.cpp. From what I can gather, wavefolding is simply inverting the portions of the waveform when its amplitude exceeds a clipping ceiling. Obviously I need to get smarter on that before I can attempt to alter someone's step() code. For now, I'm here just to apply the sed commands our boss, Mr. VCVRack, provides in "Plugin API Updates Thread #258", and upgrade the declarations and constructors accordingly.
[DIsclaimer: I use the term Mr. VCVRack in awe of this amazing project. Last year I didn't understand the maze of cables on a hardware synthesizer, now I can make simple patches. -Synth and Git Noob]

from library.

I'll adopt https://github.com/antoniograzioli/Autodafe for 0.6 upgrade, if no one else is working on it.

from library.

@hwpfeil That still doesn't answer the question of why you're using SoX instead of libsamplerate.

from library.

@hwpfeil

I'll adopt https://github.com/antoniograzioli/Autodafe for 0.6 upgrade, if no one else is working on it.

see: #269 (comment)

from library.

... why you're using SoX
Folder.cpp is GPL licensed under the Free Software Foundation; SoX Resampler is LGPL under the Free Software Foundation. Since it worked in AepelzensModules, I used it for Dekstop, too.
(Can you mix GPL and 2-clause BSD?)
There's http://wiki.audacityteam.org/wiki/Libsoxr. It was just for personal use, I never intended to change anything above the plugins directory.

from library.

Could someone check out the v2 branch of this community repo, and add all plugins to the repos/ directory as git submodules? Make sure the names of the folder exactly match their slug, and make sure the branches are the "0.6" versions. For example

git checkout v2
cd repos
git submodule add -b master https://github.com/VCVRack/Fundamental.git Fundamental

You can rename submodules with git mv <src> <dest>. Send a PR and I'll accept it.
We'll begin the approval process for repos once most of the submodules repos compile.

EDIT: Partial work is welcome as well.

from library.

Take Autodafe off the to-do list. Mr. Grazioli is updating his own plugins to 0.6.

from library.

@hwpfeil Thank you for your offer to help. Please read the second post above. All plugins are being worked on already, either by the developers or PRs have been provided (and in a lot of instances merged). The post explains what the checkmark in the list means and when a plugin gets crossed off the list. There is some cleanup to do with individual plugins, but I am going to let the developer drive those changes (for example upgrading libsamplerate). They will let us know here if they need help. Issues have been created in the developer's repositories for those instances.

from library.

@AndrewBelt I have scripted the conversion from the old community repository to the new and will provide a PR soon.

Some of the plugins are still on dev branches for the 0.6 release. I put those plugins on the dev branches and will update to master once the code becomes available there.

The first PR will include all of the crossed out plugins in the list above, i.e. plugins that we have confirmed to be building on all supported platforms.

Any changes to the list in the next week will be handled with subsequent PRs that my script can generate.

from library.

@cschol Ops, sorry I didn't note this was in charge... So do not consider my PR, please. I did a simple and rough freewill exercise, far way better a script-sourced and official work. I should manage to drawback my PR. Thank you!

EDIT: @cschol Feel free to close the present PR #320 because I have no permissions to do that :-)

from library.

Let's avoid CI entirely. CI should only automate a task which we are 100% certain we've explored all exceptions and issues by performing a task manually until it gets annoying, and I don't expect this to ever happen. Automation should only be done through Makefiles and Python scripts in the v2 branch's scripts directory (not yet existing) but should always be performed by a human. Sitting down at your computer once per day to run something like make library-check (or whatever your team is) is essentially no effort. Maintaining a remote robot to do unreviewed tasks is a recipe for disaster, and it alienates anyone that wants to contribute by making the structure and build system needlessly complex to all but the author/maintainer of the CI system.

I instead encourage your script-writing tendencies to be put toward scripts that humans will run instead. If you can't run a script manually once a day, 10 other people will happily be able to for you, and they'll be able to solve problems and add improvements as they arise.

from library.

We are doing CI every day to check the plugins and we need it right now, because things keep breaking. I am not talking about Travis CI, but just scripting enough to not have to execute every build manually. I actually just found "make dist_all", which is enough and it helped flush out a bunch of issues when I tried to build all the submodules I added. Mostly missing RACK_DIR, but some new compile errors, too.

EDIT: Maybe I shouldn't have said CI at all. Just talking about running a script that checks plugins daily. Not automatically executed.

from library.

@AndrewBelt Valley Free has a whitespace character in their slug. I assume that is not acceptable? Is there a reference anywhere that I can point to?

from library.

Some more issues opened up today (compile errors, missing RACK_DIR in Makefile). If you want to help, feel free to grab one that is not checked in the above list and create a PR. Thank you!

from library.

If I may, I'm going to rename TechTechTechnologies plugins folder from "vcv" to "TechTechTechnologies" - there are already a few "vcv_" folders, could be confusing when scanning the Plugin Browser menu.

from library.

@hwpfeil Sounds good. If you're the creator (or primary source) of a particular plugin, could you pull it into its own repo so that the Makefile is at the root?

from library.

Yes, SIr.
gitNoob need input

from library.

@hwpfeil Are you the developer of TechTechTechnologies? The slug of the plugin is TechTechTechnologies, which means that in the new plugin structure using git submodules the source directory will be called TechTechTechnologies. I am not sure we need to rename this one.

from library.

Just the upgrade monkey, not developer. There's about a dozen plugins beginning with vcv. I thought the 'vcv' would get lost for those quickly scanning the modules for a patch. Easy enough to leave it in situ, I'll be lost in a add-a-little/save/compile/run/repeat loop trying to get knobs centered in the graphics. I noticed dBiz/Verbo are off. I use max-scale for fine location work. I don't suppose anyone has a grid used to get close-enough coordinates for knobs and things?

from library.

Having a spot of bother finding RoundSmallBlackSnapKnob. There is a svg image in Rack/res, but no definition or implementation. The Plugin API thread suggests its use.

from library.

@hwpfeil Just change it to RoundBlackSnapKnob.

from library.

The knobs are centred inside a grey circle with ticks along the circumference. RoundBlack obscures the tick marks. The author used RoundSmall. I tried deriving with snap=true, but that knob, although it renders correctly, doesn't turn.
I figured out how to add a .25 grid to Inkscape so I can correctly locate the knobs to the new height. I've dozens of knobs out of place.

from library.