AppendDecorators display wrong about mpb HOT 15 CLOSED

Hi! How do you increment? If it is io operation, do you use ProxyReader?

from mpb.

Hi! thank you very much for your response.
Sorry for this late response!

Yes I use ProxyReader

from mpb.

Try higher number for EwmaETA decorator, if issue is still relevant.

from mpb.

I have tried to change EwmaETA style and put a bigger number but it's doesn't working sorry.
I use version v3.3.2

from mpb.

It's hard to say what's wrong with your code, provided snippet says nothing. Example which is using EwmaETA decorator, works as expected in v3.3.2:
https://asciinema.org/a/UcxMzSPNdlyRMckkBgNnZQ806

from mpb.

It's work very nice ETA too BUT:
when I want to replace the time with "done" at the end with this following code:

mpb.AppendDecorators(
			 	// replace ETA decorator with "done" message, OnComplete event
			 	decor.OnComplete(
			 		// ETA decorator with ewma age of 60
			 		decor.EwmaETA(decor.ET_STYLE_GO, 60), "done",
			 	),
			 ),

So when I add this code Time doesn't working anymore example:
https://asciinema.org/a/0zx1oHlqpDJuIash5eQaXN8Os

and if I add this code:

mpb.AppendDecorators(
                                decor.AverageETA(decor.ET_STYLE_GO),
			 	// replace ETA decorator with "done" message, OnComplete event
			 	decor.OnComplete(
			 		// ETA decorator with ewma age of 60
			 		decor.EwmaETA(decor.ET_STYLE_GO, 60), "done",
			 	),
			 ),

I get this:
https://asciinema.org/a/PJejQBd8T3DiPKyU0WfJH19Mw

Then if I remove the decor.OnComplete I can do what I want perfectly but without done at the end 😢
Example:
https://asciinema.org/a/rbC6xMkFlFGdrLmpMMNoeAmOc

from mpb.

Can you please paste full code sample where it doesn't work for you? As I mentioned before, example code has the same combination: decor.EmwaETA wrapped inside decor.OnComplete and both do work.

from mpb.

This is the full code:
https://github.com/exoscale/cli/blob/master/cmd/sos_upload.go
I have explained to you just earlier the different cases.

Thank you

from mpb.

Ok, if I understood correctly, your problem is when you wrap any eta decorator into OnComplete, you got zero value 0s always. And when you use it without OnComplete it is ok. Is that correct?
If so, I cannot reproduce such behaviour.
Here I use both eta wrapped into OnComplete:

	bar := p.AddBar(size,
		mpb.PrependDecorators(
			decor.CountersKibiByte("% 6.1f / % 6.1f"),
		),
		mpb.AppendDecorators(
			decor.Name("ewma: "),
			decor.OnComplete(decor.EwmaETA(decor.ET_STYLE_MMSS, float64(size)/2048), "done!"),
			decor.Name(" avg: "),
			decor.OnComplete(decor.AverageETA(decor.ET_STYLE_GO), "done!"),
			decor.Name(" ] "),
			decor.AverageSpeed(decor.UnitKiB, "% .2f"),
		),
	)

The output as expected:
https://asciinema.org/a/dUskQrJ1JnHp9qxI0miYXLSop
https://asciinema.org/a/pGOz7pLvLLUXKvJJ4yOzTOayR

from mpb.

yes it was that 👍
🎉 OKAY I have solved my problem by using:
decor.OnComplete(decor.AverageETA(decor.ET_STYLE_GO), "done!"), in AppendDecorators
instead of:
decor.OnComplete(decor.EwmaETA(decor.ET_STYLE_GO, 60), "done"), in AppendDecorators

Do you think it's come from the proxy reader? because for you it's working with both solution

ps: I have tried to replace 60 with my file size

from mpb.

Do you think it's come from the proxy reader?

No. I think it is how underlying ewma lib works.
Wen you use age > 0, it uses VariableEWMA, which requires some "warmup", before it displays something other than zero.

from mpb.

Wen you use age > 0, it uses VariableEWMA, which requires some "warmup", before it displays something other than zero.

I have tried with very big file to prevent the "warmup" but with no success 😢

Thank you very much for your help 😸

from mpb.

You're welcome! By the way, I don't recommend passing full size to EwmaETA age param, instead divide your size to something other than zero ;) Good candidate is buffer size.

from mpb.

You're welcome! By the way, I don't recommend passing full size to EwmaETA age param, instead divide your size to something other than zero ;) Good candidate is buffer size.

yes thanks you but for me EwmaETA doesn't working as I said earlier!

I have tried with very big file to prevent the "warmup" but with no success 😢

I think you dont't understand my reply so I have modified it.
I think there is a real problem with EwmaETA.

So now I only use AverageETA and It's okay for me

from mpb.

@pierre-emmanuelJ
This line seems to be part of the culprit. You suppose to pass a wrapped (proxy) reader everywhere, where io.Reader is expected, otherwise there is no guarantee that EwmaETA will work at all.

from mpb.