node-fetch missing in dependency tree about dns-over-http-resolver HOT 5 CLOSED

I think node-fetch should be added to this lib's dep list because the problem does exist when you use another lib that brings dns-over-http-resolver in.

For example, my project uses [email protected] and is facing the same issue:

/home/froyer/src/status-im/js-waku/node_modules/native-fetch/src/index.js
Cannot find module: 'node-fetch'. Make sure this package is installed.

from dns-over-http-resolver.

Hey folks, thanks for reaching out and apologies for the late answer.
We need to use an environment agnostic fetch implementation here, given we want to support both browser and Node.js.

We can go with https://github.com/web-std/io/tree/main/fetch to make this possible. Any of you would like to submit a PR?

from dns-over-http-resolver.

The multi-platform compatibility does make this harder to tackle. Axios and isomorphic-fetch are another 2 possible platform-agnostic tools that may help.
As I do not need to use this library anymore, I won't have enough time and testing cases for making a fix. The issue can be kept open to track the progress tho.

from dns-over-http-resolver.

It somehow got fixed in my project after some npm clean up 🤔

from dns-over-http-resolver.

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from dns-over-http-resolver.