Docker TTY error about toolbox HOT 7 CLOSED

So I’ve just had time to look at this again and vapor docker enter is working with tty support in the 06-20 branch which was where I’d left off the conversion to 3.0: https://github.com/qutheory/vapor-toolbox/tree/swift-06-20

I should have opened a PR for that branch at the time, I think it got lost in the transition that I’d been migrating and testing this stuff. It was all a bit wild with the 3.0 changes causing trouble left, right, and centre.

So the answer is to merge those changes in my 06-20 branch into master. It’s using posix_spawnp to replace all system commands.

from toolbox.

I need to check but didn’t the initial adaptation for 3.0-preview1 I pushed use posix_spawn?

from toolbox.

Actually, it seems like it’s something I tried but didn’t add it. This was adapted from SwiftPM, here’s a gist to it for reference: https://gist.github.com/feinstruktur/eff754257652cec27aba63e7c556dc70

from toolbox.

I haven’t had time to clean this up but there’s now a working version of a posix_spawnp based drop in replacement for system in console: https://github.com/vapor/console/blob/posix_spawnp/Sources/POSIX/popen2.swift

See vapor/console-kit@c870420 (in main.swift) for an example.

from toolbox.

Swell, posix_spawn_file_actions_addinherit_np is not available on Linux apparently :/ Looking for a workaround.

from toolbox.

This should do the trick: vapor/console-kit@028186a

from toolbox.

Closing this due to inactivity. Please feel free to reopen.

from toolbox.