Comments (5)
@tanner0101 Yes, I suspect that check doesn't support symlinks. I will do a fork and test with it. If it works, I could put a PR for it.
from heroku-buildpack.
@honghaoz what is the error you are getting?
from heroku-buildpack.
Hey @tanner0101 here is the error log:
➜ XXX git:(master) git push heroku master
Counting objects: 131, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (102/102), done.
Writing objects: 100% (131/131), 69.21 KiB | 4.33 MiB/s, done.
Total 131 (delta 33), reused 0 (delta 0)
remote: Compressing source files... done.
remote: Building source:
remote:
remote: -----> App not compatible with buildpack: https://github.com/vapor-community/heroku-buildpack
remote: More info: https://devcenter.heroku.com/articles/buildpacks#detection-failure
remote:
remote: ! Push failed
remote: Verifying deploy...
remote:
remote: ! Push rejected to XXX.
remote:
To https://git.heroku.com/XXX.git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.heroku.com/XXX.git'
from heroku-buildpack.
I don't know much about Heroku buildpacks, but my guess is the problem is here: https://github.com/vapor-community/heroku-buildpack/blob/master/bin/detect#L4
Seems like we need to expand that check to support symlinks. Maybe this will help: https://stackoverflow.com/questions/5767062/how-to-check-if-a-symlink-exists
from heroku-buildpack.
I found this error was caused by the symlink's absolute path of the source file.
Specifically,
This was the bad symlink:
Package.swift -> <absolute path>/Environment/production/Package.swift
After I changed the symlink to
Package.swift -> ./Environment/production/Package.swift
The buildpack works well.
Credit to this post: https://www.mokacoding.com/blog/symliks-in-git/
from heroku-buildpack.
Related Issues (18)
- No such file or directory HOT 1
- Update buildpack for Swift 4 and newer clang
- Fix ubuntu version detection
- xz:(stdin): File format not recognized HOT 5
- swiftenv fails on heroku push HOT 4
- Heroku build fails HOT 4
- Request: Support Heroku 18 stack HOT 7
- Error while using swift 5 HOT 2
- No such module 'CommonCrypto' HOT 2
- Migrate away from swiftenv HOT 1
- Building failing on release script HOT 1
- Heroku build failed to compile Swift app HOT 1
- Support for Heroku-20 stack HOT 3
- updated to latest buildpack and heroku-20: No available connections on this event loop, creating a new one [database-id: psql] HOT 2
- Support for resources
- Bundle.module does not find resources after deployment HOT 8
- Heroku-22 stack HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroku-buildpack.